Skip to content

Commit d4c0ade

Browse files
danakjAravind Vasudevan
authored andcommitted
Turn off PIC for LLVM/Clang built for binary distribution.
It's only needed for the Rust LLVM build, and that's done separately, so we can do that through an argument to build.py. Bug: 1245714 Change-Id: Ib2dca642961e42774e066b4d81e4ec57194090ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4458170 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#1139175} NOKEYCHECK=True GitOrigin-RevId: 99582262afd2be84d21879ac8087ec999e2c9bbb
1 parent 4e3e95a commit d4c0ade

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

build_rust.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -541,6 +541,8 @@ def BuildLLVMLibraries(skip_build, build_mac_arm, gcc_toolchain):
541541
os.path.join(CLANG_SCRIPTS_DIR, 'build.py'),
542542
'--disable-asserts',
543543
'--no-tools',
544+
# PIC needed for Rust build (links LLVM into shared object)
545+
'--pic',
544546
'--with-ml-inliner-model=',
545547
]
546548
if sys.platform.startswith('linux'):

0 commit comments

Comments
 (0)