Skip to content

Commit 99f61e3

Browse files
danakjAravind Vasudevan
authored andcommitted
Disable tests/codegen/vec-shrink-panik.rs globally.
rust-lang/rust#96464 The test used to fail on Windows only but now fails everywhere. The Rust CI skips this test as they run in debug mode and the test does not run in Debug mode, so we will hit failures before upstream does here. This failure is likely being hit due to TOT LLVM though, which upstream does not use. R=hans@chromium.org Bug: 1401042 Change-Id: Ie379559f318f3b7bd57c5db4cd21806218bcb373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4517966 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#1141656} NOKEYCHECK=True GitOrigin-RevId: 615dc990ad51de55d4159ad162d154b00b6e0395
1 parent e29e413 commit 99f61e3

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

build_rust.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@
7474
os.path.join('tests', 'codegen', 'sanitizer-cfi-emit-type-checks.rs'),
7575
os.path.join('tests', 'codegen',
7676
'sanitizer-cfi-emit-type-metadata-itanium-cxx-abi.rs'),
77+
# https://github.com/rust-lang/rust/issues/96464 used to be Windows only but
78+
# now fails everywhere.
79+
os.path.join('tests', 'codegen', 'vec-shrink-panik.rs'),
7780
# https://github.com/rust-lang/rust/issues/109671 the test is being
7881
# optimized in newer LLVM which breaks its expectations.
7982
os.path.join('tests', 'ui', 'abi', 'stack-protector.rs'),
@@ -85,8 +88,6 @@
8588
os.path.join('tests', 'ui', 'numeric', 'numeric-cast.rs'),
8689
]
8790
EXCLUDED_TESTS_WINDOWS = [
88-
# https://github.com/rust-lang/rust/issues/96464
89-
os.path.join('tests', 'codegen', 'vec-shrink-panik.rs'),
9091
# TODO(crbug.com/1442943): Re-enable when fixed.
9192
os.path.join('tests', 'ui', 'native-library-link-flags',
9293
'msvc-non-utf8-output.rs'),

0 commit comments

Comments
 (0)