Skip to content

Commit 4023806

Browse files
danakjcopybara-github
authored andcommitted
Remove crubit todo about using //third_party/rust
crubit is part of the toolchain, so it has very different dependencies than chromium does. We use upstream crates to build the toolchain, including rustc, cargo, bindgen, etc. R=lukasza@chromium.org Bug: 40229252 Change-Id: Iaf324a1895df8b57f944d1ea86bca33181c5edab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5726076 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1330428} NOKEYCHECK=True GitOrigin-RevId: 758a505cef2396f7f889346eda963647b717fec2
1 parent 2a9ec82 commit 4023806

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

build_crubit.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ def CheckoutCrubit(commit, dir):
9797
def BuildCrubit(build_mac_arm):
9898
# TODO(crbug.com/40229251): Use locally built Rust instead of having
9999
# Bazel always download the whole Rust toolchain from the internet.
100-
# TODO(crbug.com/40229252): Use crates from chromium/src/third_party/rust.
101100

102101
# This environment variable is consumed by crubit/bazel/llvm.bzl and will
103102
# configure Crubit's build to include and link against LLVM+Clang headers

0 commit comments

Comments
 (0)