Skip to content

Commit eb2cd97

Browse files
committed
Replace bare issue numbers with URLs
This should hopefully make it easier to see which repo a given issue is referring to.
1 parent f4c384d commit eb2cd97

File tree

6 files changed

+20
-8
lines changed

6 files changed

+20
-8
lines changed

scripts/core/enqueue.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,9 @@ desc: "Enqueue a command to fill an image object with specified color"
782782
class: $xEnqueue
783783
name: MemImageFill
784784
ordinal: "0"
785-
version: "9999.0" # see #50
785+
# Will not be generated
786+
# https://github.com/oneapi-src/unified-runtime/issues/50
787+
version: "9999.0"
786788
details:
787789
- "Currently not implemented in Level Zero"
788790
- "TODO: add a driver function in Level Zero?"
@@ -919,7 +921,9 @@ type: function
919921
desc: "Enqueue a command to map a region of the image object into the host address space and return a pointer to the mapped region"
920922
class: $xEnqueue
921923
name: MemImageMap
922-
version: "9999.0" # See #50
924+
# Will not be generated
925+
# https://github.com/oneapi-src/unified-runtime/issues/50
926+
version: "9999.0"
923927
ordinal: "0"
924928
details:
925929
- "Input parameter blockingMap indicates if the map is blocking or non-blocking."

scripts/core/event.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,18 @@ etors:
4343
desc: Event created by $xEnqueueMemImageWrite
4444
- name: MEM_IMAGE_COPY
4545
desc: Event created by $xEnqueueMemImageCopy
46+
# Will not be generated
47+
# https://github.com/oneapi-src/unified-runtime/issues/50
4648
- name: MEM_IMAGE_FILL
4749
desc: Event created by $xEnqueueMemImageFill
48-
version: "9999.0" # See #50
50+
version: "9999.0"
4951
- name: MEM_BUFFER_MAP
5052
desc: Event created by $xEnqueueMemBufferMap
53+
# Will not be generated
54+
# https://github.com/oneapi-src/unified-runtime/issues/50
5155
- name: MEM_IMAGE_MAP
5256
desc: Event created by $xEnqueueMemImageMap
53-
version: "9999.0" # See #50
57+
version: "9999.0"
5458
- name: MEM_UNMAP
5559
desc: Event created by $xEnqueueMemUnmap
5660
- name: USM_FILL

source/adapters/cuda/adapter.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ class ur_legacy_sink : public logger::Sink {
3838
};
3939

4040
// FIXME: Remove the default log level when querying logging info is supported
41-
// through UR entry points. See #1330.
41+
// through UR entry points.
42+
// https://github.com/oneapi-src/unified-runtime/issues/1330
4243
ur_adapter_handle_t_::ur_adapter_handle_t_()
4344
: logger(logger::get_logger("cuda",
4445
/*default_log_level*/ logger::Level::ERR)) {

source/adapters/cuda/memory.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@
1717

1818
/// Creates a UR Memory object using a CUDA memory allocation.
1919
/// Can trigger a manual copy depending on the mode.
20-
/// \TODO Implement USE_HOST_PTR using cuHostRegister - See #9789
20+
/// \TODO Implement USE_HOST_PTR using cuHostRegister
21+
/// https://github.com/intel/llvm/issues/9789
2122
///
2223
UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
2324
ur_context_handle_t hContext, ur_mem_flags_t flags, size_t size,

source/adapters/hip/adapter.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ class ur_legacy_sink : public logger::Sink {
3737
};
3838

3939
// FIXME: Remove the default log level when querying logging info is supported
40-
// through UR entry points. See #1330.
40+
// through UR entry points.
41+
// https://github.com/oneapi-src/unified-runtime/issues/1330
4142
ur_adapter_handle_t_::ur_adapter_handle_t_()
4243
: logger(
4344
logger::get_logger("hip", /*default_log_level*/ logger::Level::ERR)) {

source/adapters/hip/memory.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemRelease(ur_mem_handle_t hMem) {
9090

9191
/// Creates a UR Memory object using a HIP memory allocation.
9292
/// Can trigger a manual copy depending on the mode.
93-
/// \TODO Implement USE_HOST_PTR using hipHostRegister - See #9789
93+
/// \TODO Implement USE_HOST_PTR using hipHostRegister
94+
/// https://github.com/intel/llvm/issues/9789
9495
UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
9596
ur_context_handle_t hContext, ur_mem_flags_t flags, size_t size,
9697
const ur_buffer_properties_t *pProperties, ur_mem_handle_t *phBuffer) {

0 commit comments

Comments
 (0)