Skip to content

Commit e75a62b

Browse files
author
Damian Duy
committed
[ur] fix minor coverity issues
1 parent e818777 commit e75a62b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

test/conformance/source/environment.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ void DevicesEnvironment::TearDown() {
195195
KernelsEnvironment *KernelsEnvironment::instance = nullptr;
196196

197197
KernelsEnvironment::KernelsEnvironment(int argc, char **argv,
198-
std::string kernels_default_dir)
198+
const std::string &kernels_default_dir)
199199
: DevicesEnvironment(argc, argv),
200200
kernel_options(parseKernelOptions(argc, argv, kernels_default_dir)) {
201201
instance = this;
@@ -206,7 +206,7 @@ KernelsEnvironment::KernelsEnvironment(int argc, char **argv,
206206

207207
KernelsEnvironment::KernelOptions
208208
KernelsEnvironment::parseKernelOptions(int argc, char **argv,
209-
std::string kernels_default_dir) {
209+
const std::string &kernels_default_dir) {
210210
KernelOptions options;
211211
for (int argi = 1; argi < argc; ++argi) {
212212
const char *arg = argv[argi];

test/conformance/testing/include/uur/environment.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ struct KernelsEnvironment : DevicesEnvironment {
5252
std::string kernel_directory;
5353
};
5454

55-
KernelsEnvironment(int argc, char **argv, std::string kernels_default_dir);
55+
KernelsEnvironment(int argc, char **argv,
56+
const std::string &kernels_default_dir);
5657
virtual ~KernelsEnvironment() override = default;
5758

5859
virtual void SetUp() override;
@@ -65,7 +66,7 @@ struct KernelsEnvironment : DevicesEnvironment {
6566

6667
private:
6768
KernelOptions parseKernelOptions(int argc, char **argv,
68-
std::string kernels_default_dir);
69+
const std::string &kernels_default_dir);
6970
std::string getKernelSourcePath(const std::string &kernel_name,
7071
uint32_t device_index);
7172
std::string getSupportedILPostfix(uint32_t device_index);

0 commit comments

Comments
 (0)