Skip to content

Commit d9d24ec

Browse files
authored
sycl-bench added & ascii bar chart (#2115)
1 parent bcd9032 commit d9d24ec

File tree

8 files changed

+595
-94
lines changed

8 files changed

+595
-94
lines changed

scripts/benchmarks/benches/base.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import os
77
import shutil
88
from pathlib import Path
9-
import subprocess # nosec B404
109
from .result import Result
1110
from .options import options
1211
from utils.utils import run
@@ -57,7 +56,7 @@ def lower_is_better(self):
5756
def setup(self):
5857
raise NotImplementedError()
5958

60-
def run(self, env_vars) -> Result:
59+
def run(self, env_vars) -> list[Result]:
6160
raise NotImplementedError()
6261

6362
def teardown(self):

scripts/benchmarks/benches/compute.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def setup(self):
6565
self.bench.setup()
6666
self.benchmark_bin = os.path.join(self.bench.bins, self.bench_name)
6767

68-
def run(self, env_vars) -> Result:
68+
def run(self, env_vars) -> list[Result]:
6969
command = [
7070
f"{self.benchmark_bin}",
7171
f"--test={self.test}",
@@ -78,7 +78,7 @@ def run(self, env_vars) -> Result:
7878

7979
result = self.run_bench(command, env_vars)
8080
(label, mean) = self.parse_output(result)
81-
return Result(label=label, value=mean, command=command, env=env_vars, stdout=result, lower_is_better=self.lower_is_better())
81+
return [ Result(label=self.name(), value=mean, command=command, env=env_vars, stdout=result, lower_is_better=self.lower_is_better()) ]
8282

8383
def parse_output(self, output):
8484
csv_file = io.StringIO(output)

scripts/benchmarks/benches/quicksilver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def __init__(self, vb: VelocityBench):
1515
super().__init__("QuickSilver", "qs", vb)
1616
self.data_path = os.path.join(vb.repo_path, "QuickSilver", "Examples", "AllScattering")
1717

18-
def run(self, env_vars) -> Result:
18+
def run(self, env_vars) -> list[Result]:
1919
# TODO: fix the crash in QuickSilver when UR_L0_USE_IMMEDIATE_COMMANDLISTS=0
2020
if 'UR_L0_USE_IMMEDIATE_COMMANDLISTS' in env_vars and env_vars['UR_L0_USE_IMMEDIATE_COMMANDLISTS'] == '0':
2121
return None

0 commit comments

Comments
 (0)