Merge pull request #1987 from npmiller/load-log

omarahmed1111 · web-flow · commit d88215ce48c9 · 2024-08-19T12:51:59.000+01:00
Add dlerror output to loader logs
diff --git a/source/common/linux/ur_lib_loader.cpp b/source/common/linux/ur_lib_loader.cpp
@@ -45,7 +45,13 @@ LibLoader::loadAdapterLibrary(const char *name) {
     }
 #endif
     HMODULE handle = dlopen(name, mode);
-    logger::info("loaded adapter 0x{} ({})", handle, name);
+    if (!handle) {
+        char *err = dlerror();
+        logger::info("failed to load adapter '{}' with error: {}", name,
+                     err ? err : "unknown error");
+    } else {
+        logger::info("loaded adapter 0x{} ({})", handle, name);
+    }
     return std::unique_ptr<HMODULE, LibLoader::lib_dtor>(handle);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,13 @@ LibLoader::loadAdapterLibrary(const char *name) {`
`45`	`45`	`}`
`46`	`46`	`#endif`
`47`	`47`	`HMODULE handle = dlopen(name, mode);`
`48`		`- logger::info("loaded adapter 0x{} ({})", handle, name);`
	`48`	`+ if (!handle) {`
	`49`	`+ char *err = dlerror();`
	`50`	`+ logger::info("failed to load adapter '{}' with error: {}", name,`
	`51`	`+ err ? err : "unknown error");`
	`52`	`+ } else {`
	`53`	`+ logger::info("loaded adapter 0x{} ({})", handle, name);`
	`54`	`+ }`
`49`	`55`	`return std::unique_ptr<HMODULE, LibLoader::lib_dtor>(handle);`
`50`	`56`	`}`
`51`	`57`