Merge branch 'petr/fix-hip-sync' into benie/hip-cts-fixes-combined

Author: kbenzie

source/adapters/hip/device.cpp

@@ -939,21 +939,18 @@ ur_result_t UR_APICALL urDeviceGetGlobalTimestamps(ur_device_handle_t hDevice,
   if (pDeviceTimestamp) {
     UR_CHECK_ERROR(hipEventCreateWithFlags(&Event, hipEventDefault));
     UR_CHECK_ERROR(hipEventRecord(Event));
-  }
-  if (pHostTimestamp) {
-    using namespace std::chrono;
-    *pHostTimestamp =
-        duration_cast<nanoseconds>(steady_clock::now().time_since_epoch())
-            .count();
-  }
-
-  if (pDeviceTimestamp) {
     UR_CHECK_ERROR(hipEventSynchronize(Event));
     float ElapsedTime = 0.0f;
     UR_CHECK_ERROR(hipEventElapsedTime(&ElapsedTime,
                                        ur_platform_handle_t_::EvBase, Event));
     *pDeviceTimestamp = (uint64_t)(ElapsedTime * (double)1e6);
   }
 
+  if (pHostTimestamp) {
+    using namespace std::chrono;
+    *pHostTimestamp =
+        duration_cast<nanoseconds>(steady_clock::now().time_since_epoch())
+            .count();
+  }
   return UR_RESULT_SUCCESS;
 }

source/adapters/hip/platform.cpp

@@ -9,6 +9,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "platform.hpp"
+#include "context.hpp"
 
 hipEvent_t ur_platform_handle_t_::EvBase{nullptr};
 
@@ -90,6 +91,16 @@ urPlatformGet(ur_adapter_handle_t *, uint32_t, uint32_t NumEntries,
               PlatformIds[i].Devices.emplace_back(
                   new ur_device_handle_t_{Device, Context, &PlatformIds[i]});
             }
+
+            // Setup EvBase
+            {
+              ScopedContext Active(PlatformIds.front().Devices.front().get());
+              hipEvent_t EvBase;
+              UR_CHECK_ERROR(hipEventCreate(&EvBase));
+              UR_CHECK_ERROR(hipEventRecord(EvBase, 0));
+
+              ur_platform_handle_t_::EvBase = EvBase;
+            }
           } catch (const std::bad_alloc &) {
             // Signal out-of-memory situation
             for (int i = 0; i < NumDevices; ++i) {

test/conformance/device/device_adapter_hip.match

@@ -1,6 +1,5 @@
 {{OPT}}urDeviceCreateWithNativeHandleTest.Success
 {{OPT}}urDeviceGetTest.InvalidValueNumEntries
-{{OPT}}urDeviceGetGlobalTimestampTest.Success
 {{OPT}}urDeviceGetGlobalTimestampTest.SuccessSynchronizedTime
 {{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_SINGLE_FP_CONFIG
 {{OPT}}urDeviceGetInfoTest.Success/UR_DEVICE_INFO_DOUBLE_FP_CONFIG