Skip to content

Commit caee5fe

Browse files
authored
Merge pull request #1306 from kbenzie/benie/update-adapter-change-process
[Docs] Update the Adapter Change Process
2 parents 3696d46 + e207ed9 commit caee5fe

File tree

1 file changed

+25
-5
lines changed

1 file changed

+25
-5
lines changed

scripts/core/CONTRIB.rst

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,22 +75,42 @@ Adapter Change Process
7575
accompanied by a corresponding update in the *intel/llvm* pull request as
7676
indicated in step 2, so the testing is always up-to-date.
7777

78-
6. The Unified Runtime maintainers *must* ensure that step 5 has been carried
79-
out and that all pre-merge testing has passed before accepting the
78+
6. Once the *oneapi-src/unified-runtime* pull request has been approved by at
79+
least one member of each relevant code-owner team:
80+
81+
* Make the *intel/llvm* pull request ready to review (remove draft) in
82+
order to gain approvals from all code-owners to ensure step 8 can
83+
progress quickly when the time comes.
84+
85+
* Add the *ready to merge* label to the *oneapi-src/unified-runtime* pull
86+
request.
87+
88+
7. The Unified Runtime maintainers *must* ensure that step 5 has been carried
89+
out and that all pre-merge testing has passed before merging the
8090
*oneapi-src/unified-runtime* pull request.
8191

82-
7. Once the *oneapi-src/unified-runtime* pull request is accepted:
92+
* The oldest pull requests with the *ready to merge* label will be
93+
prioritized.
94+
95+
* Contact the Unified Runtime maintainers if a pull request should be
96+
given a higher priority.
97+
98+
8. Once the *oneapi-src/unified-runtime* pull request has been merged:
8399

84100
* Reverse the change to `UNIFIED_RUNTIME_REPO`_ made in step 2.
101+
85102
* Update the `UNIFIED_RUNTIME_TAG`_ to point at the
86103
*oneapi-src/unified-runtime* commit/tag containing the merged adapter
87104
changes.
105+
88106
* Update the pull request description, linking to any other *intel/llvm*
89107
pull requests who's changes have been merged into
90108
*oneapi-src/unified-runtime* but have not yet been merge into
91109
*intel/llvm*.
92-
* Mark the *intel/llvm* pull request as ready for review and follow their
93-
review process.
110+
111+
* A Unified Runtime maintainer may facilitate these steps either by
112+
making suggestions on the *intel/llvm* pull request or by making those
113+
changes directly.
94114

95115
.. _oneapi-src/unified-runtime:
96116
https://github.com/oneapi-src/unified-runtime

0 commit comments

Comments
 (0)