Skip to content

Commit c85400d

Browse files
veselypetafabiomestre
authored andcommitted
[PI][UR][HIP][CUDA][L0][NCPU] Pull in latest UR fixes. (#11155)
Fetch the latest revision of unified runtime: Notable changes * Some command buffer entry-points have been renamed, also 2 additions of membufferFill and USMFill * UrInit/urTearDown have been removed - replaced with loader only versions.
1 parent ad82940 commit c85400d

File tree

3 files changed

+38
-29
lines changed

3 files changed

+38
-29
lines changed

adapter.cpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,6 @@ struct ur_adapter_handle_t_ {
2020

2121
ur_adapter_handle_t_ adapter{};
2222

23-
UR_APIEXPORT ur_result_t UR_APICALL urInit(ur_device_init_flags_t,
24-
ur_loader_config_handle_t) {
25-
return UR_RESULT_SUCCESS;
26-
}
27-
28-
UR_APIEXPORT ur_result_t UR_APICALL urTearDown(void *) {
29-
return UR_RESULT_SUCCESS;
30-
}
31-
3223
UR_APIEXPORT ur_result_t UR_APICALL
3324
urAdapterGet(uint32_t NumEntries, ur_adapter_handle_t *phAdapters,
3425
uint32_t *pNumAdapters) {

command_buffer.cpp

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendKernelLaunchExp(
7373
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
7474
}
7575

76-
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemcpyUSMExp(
76+
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMMemcpyExp(
7777
ur_exp_command_buffer_handle_t hCommandBuffer, void *pDst, const void *pSrc,
7878
size_t size, uint32_t numSyncPointsInWaitList,
7979
const ur_exp_command_buffer_sync_point_t *pSyncPointWaitList,
@@ -91,7 +91,16 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemcpyUSMExp(
9191
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
9292
}
9393

94-
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMembufferCopyExp(
94+
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendUSMFillExp(
95+
ur_exp_command_buffer_handle_t, void *, const void *, size_t, size_t,
96+
uint32_t, const ur_exp_command_buffer_sync_point_t *,
97+
ur_exp_command_buffer_sync_point_t *) {
98+
detail::ur::die("Experimental Command-buffer feature is not "
99+
"implemented for CUDA adapter.");
100+
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
101+
}
102+
103+
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferCopyExp(
95104
ur_exp_command_buffer_handle_t hCommandBuffer, ur_mem_handle_t hSrcMem,
96105
ur_mem_handle_t hDstMem, size_t srcOffset, size_t dstOffset, size_t size,
97106
uint32_t numSyncPointsInWaitList,
@@ -112,7 +121,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMembufferCopyExp(
112121
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
113122
}
114123

115-
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMembufferCopyRectExp(
124+
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferCopyRectExp(
116125
ur_exp_command_buffer_handle_t hCommandBuffer, ur_mem_handle_t hSrcMem,
117126
ur_mem_handle_t hDstMem, ur_rect_offset_t srcOrigin,
118127
ur_rect_offset_t dstOrigin, ur_rect_region_t region, size_t srcRowPitch,
@@ -140,7 +149,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMembufferCopyRectExp(
140149
}
141150

142151
UR_APIEXPORT
143-
ur_result_t UR_APICALL urCommandBufferAppendMembufferWriteExp(
152+
ur_result_t UR_APICALL urCommandBufferAppendMemBufferWriteExp(
144153
ur_exp_command_buffer_handle_t hCommandBuffer, ur_mem_handle_t hBuffer,
145154
size_t offset, size_t size, const void *pSrc,
146155
uint32_t numSyncPointsInWaitList,
@@ -161,7 +170,7 @@ ur_result_t UR_APICALL urCommandBufferAppendMembufferWriteExp(
161170
}
162171

163172
UR_APIEXPORT
164-
ur_result_t UR_APICALL urCommandBufferAppendMembufferReadExp(
173+
ur_result_t UR_APICALL urCommandBufferAppendMemBufferReadExp(
165174
ur_exp_command_buffer_handle_t hCommandBuffer, ur_mem_handle_t hBuffer,
166175
size_t offset, size_t size, void *pDst, uint32_t numSyncPointsInWaitList,
167176
const ur_exp_command_buffer_sync_point_t *pSyncPointWaitList,
@@ -181,7 +190,7 @@ ur_result_t UR_APICALL urCommandBufferAppendMembufferReadExp(
181190
}
182191

183192
UR_APIEXPORT
184-
ur_result_t UR_APICALL urCommandBufferAppendMembufferWriteRectExp(
193+
ur_result_t UR_APICALL urCommandBufferAppendMemBufferWriteRectExp(
185194
ur_exp_command_buffer_handle_t hCommandBuffer, ur_mem_handle_t hBuffer,
186195
ur_rect_offset_t bufferOffset, ur_rect_offset_t hostOffset,
187196
ur_rect_region_t region, size_t bufferRowPitch, size_t bufferSlicePitch,
@@ -209,7 +218,7 @@ ur_result_t UR_APICALL urCommandBufferAppendMembufferWriteRectExp(
209218
}
210219

211220
UR_APIEXPORT
212-
ur_result_t UR_APICALL urCommandBufferAppendMembufferReadRectExp(
221+
ur_result_t UR_APICALL urCommandBufferAppendMemBufferReadRectExp(
213222
ur_exp_command_buffer_handle_t hCommandBuffer, ur_mem_handle_t hBuffer,
214223
ur_rect_offset_t bufferOffset, ur_rect_offset_t hostOffset,
215224
ur_rect_region_t region, size_t bufferRowPitch, size_t bufferSlicePitch,
@@ -251,3 +260,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferEnqueueExp(
251260
"implemented for CUDA adapter.");
252261
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
253262
}
263+
264+
UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferAppendMemBufferFillExp(
265+
ur_exp_command_buffer_handle_t, ur_mem_handle_t, const void *, size_t,
266+
size_t, size_t, uint32_t, const ur_exp_command_buffer_sync_point_t *,
267+
ur_exp_command_buffer_sync_point_t *) {
268+
detail::ur::die("Experimental Command-buffer feature is not "
269+
"implemented for CUDA adapter.");
270+
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
271+
}

ur_interface_loader.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,6 @@ UR_DLLEXPORT ur_result_t UR_APICALL urGetGlobalProcAddrTable(
200200
if (UR_RESULT_SUCCESS != result) {
201201
return result;
202202
}
203-
pDdiTable->pfnInit = urInit;
204-
pDdiTable->pfnTearDown = urTearDown;
205203
pDdiTable->pfnAdapterGet = urAdapterGet;
206204
pDdiTable->pfnAdapterRelease = urAdapterRelease;
207205
pDdiTable->pfnAdapterRetain = urAdapterRetain;
@@ -278,17 +276,19 @@ UR_DLLEXPORT ur_result_t UR_APICALL urGetCommandBufferExpProcAddrTable(
278276
pDdiTable->pfnReleaseExp = urCommandBufferReleaseExp;
279277
pDdiTable->pfnFinalizeExp = urCommandBufferFinalizeExp;
280278
pDdiTable->pfnAppendKernelLaunchExp = urCommandBufferAppendKernelLaunchExp;
281-
pDdiTable->pfnAppendMemcpyUSMExp = urCommandBufferAppendMemcpyUSMExp;
282-
pDdiTable->pfnAppendMembufferCopyExp = urCommandBufferAppendMembufferCopyExp;
283-
pDdiTable->pfnAppendMembufferCopyRectExp =
284-
urCommandBufferAppendMembufferCopyRectExp;
285-
pDdiTable->pfnAppendMembufferReadExp = urCommandBufferAppendMembufferReadExp;
286-
pDdiTable->pfnAppendMembufferReadRectExp =
287-
urCommandBufferAppendMembufferReadRectExp;
288-
pDdiTable->pfnAppendMembufferWriteExp =
289-
urCommandBufferAppendMembufferWriteExp;
290-
pDdiTable->pfnAppendMembufferWriteRectExp =
291-
urCommandBufferAppendMembufferWriteRectExp;
279+
pDdiTable->pfnAppendUSMMemcpyExp = urCommandBufferAppendUSMMemcpyExp;
280+
pDdiTable->pfnAppendUSMFillExp = urCommandBufferAppendUSMFillExp;
281+
pDdiTable->pfnAppendMemBufferCopyExp = urCommandBufferAppendMemBufferCopyExp;
282+
pDdiTable->pfnAppendMemBufferCopyRectExp =
283+
urCommandBufferAppendMemBufferCopyRectExp;
284+
pDdiTable->pfnAppendMemBufferReadExp = urCommandBufferAppendMemBufferReadExp;
285+
pDdiTable->pfnAppendMemBufferReadRectExp =
286+
urCommandBufferAppendMemBufferReadRectExp;
287+
pDdiTable->pfnAppendMemBufferWriteExp =
288+
urCommandBufferAppendMemBufferWriteExp;
289+
pDdiTable->pfnAppendMemBufferWriteRectExp =
290+
urCommandBufferAppendMemBufferWriteRectExp;
291+
pDdiTable->pfnAppendMemBufferFillExp = urCommandBufferAppendMemBufferFillExp;
292292
pDdiTable->pfnEnqueueExp = urCommandBufferEnqueueExp;
293293

294294
return retVal;

0 commit comments

Comments
 (0)