[UR] fix warnings in collector

Author: Petr Vesely

examples/collector/collector.cpp

@@ -82,10 +82,10 @@ static std::unordered_map<
  * On begin, it prints the function declaration with the call arguments specified,
  * and on end it prints the function name with the result of the call.
  */
-XPTI_CALLBACK_API void trace_cb(uint16_t trace_type,
-                                xpti::trace_event_data_t *parent,
-                                xpti::trace_event_data_t *event,
-                                uint64_t instance, const void *user_data) {
+XPTI_CALLBACK_API void
+trace_cb(uint16_t trace_type, [[maybe_unused]] xpti::trace_event_data_t *parent,
+         [[maybe_unused]] xpti::trace_event_data_t *event, uint64_t instance,
+         const void *user_data) {
     auto *args = static_cast<const xpti::function_with_args_t *>(user_data);
     std::ostringstream out;
     if (trace_type == TRACE_FN_BEGIN) {
@@ -120,7 +120,7 @@ XPTI_CALLBACK_API void trace_cb(uint16_t trace_type,
  */
 XPTI_CALLBACK_API void xptiTraceInit(unsigned int major_version,
                                      unsigned int minor_version,
-                                     const char *version_str,
+                                     [[maybe_unused]] const char *version_str,
                                      const char *stream_name) {
     if (stream_name == nullptr) {
         std::cout << "Stream name not provided. Aborting." << std::endl;
@@ -158,5 +158,6 @@ XPTI_CALLBACK_API void xptiTraceInit(unsigned int major_version,
  *
  * Can be used to cleanup state or resources.
  */
-XPTI_CALLBACK_API void xptiTraceFinish(const char *stream_name) { /* noop */
+XPTI_CALLBACK_API void
+xptiTraceFinish([[maybe_unused]] const char *stream_name) { /* noop */
 }

source/common/ur_params.hpp

@@ -454,18 +454,17 @@ inline std::ostream &operator<<(std::ostream &os,
                                 enum ur_exp_image_copy_flag_t value);
 inline std::ostream &
 operator<<(std::ostream &os,
-           const struct ur_exp_sampler_mip_properties_t params);
-inline std::ostream &
-operator<<(std::ostream &os, const struct ur_exp_sampler_addr_modes_t params);
-inline std::ostream &operator<<(std::ostream &os,
-                                const struct ur_exp_interop_mem_desc_t params);
+           [[maybe_unused]] const struct ur_exp_file_descriptor_t params);
 inline std::ostream &
 operator<<(std::ostream &os,
            [[maybe_unused]] const struct ur_exp_win32_handle_t params);
 inline std::ostream &operator<<(
     std::ostream &os,
     [[maybe_unused]] const struct ur_exp_sampler_mip_properties_t params);
 inline std::ostream &
+operator<<(std::ostream &os,
+           [[maybe_unused]] const struct ur_exp_sampler_addr_modes_t params);
+inline std::ostream &
 operator<<(std::ostream &os,
            [[maybe_unused]] const struct ur_exp_interop_mem_desc_t params);
 inline std::ostream &operator<<(
@@ -13048,9 +13047,9 @@ inline std::ostream &operator<<(
     return os;
 }
 
-inline std::ostream &operator<<(
-    std::ostream &os,
-    const struct ur_enqueue_cooperative_kernel_launch_exp_params_t *params) {
+inline std::ostream &
+operator<<(std::ostream &os, [[maybe_unused]] const struct
+           ur_enqueue_cooperative_kernel_launch_exp_params_t *params) {
 
     os << ".hQueue = ";
 
@@ -13667,10 +13666,9 @@ operator<<(std::ostream &os, [[maybe_unused]] const struct
     return os;
 }
 
-inline std::ostream &operator<<(
-    std::ostream &os,
-    const struct ur_kernel_suggest_max_cooperative_group_count_exp_params_t
-        *params) {
+inline std::ostream &
+operator<<(std::ostream &os, [[maybe_unused]] const struct
+           ur_kernel_suggest_max_cooperative_group_count_exp_params_t *params) {
 
     os << ".hKernel = ";
 
@@ -13684,8 +13682,9 @@ inline std::ostream &operator<<(
     return os;
 }
 
-inline std::ostream &operator<<(std::ostream &os,
-                                const struct ur_loader_init_params_t *params) {
+inline std::ostream &
+operator<<(std::ostream &os,
+           [[maybe_unused]] const struct ur_loader_init_params_t *params) {
 
     os << ".device_flags = ";
 

tools/urtrace/collector.cpp

@@ -245,10 +245,12 @@ class JsonWriter : public TraceWriter {
             "\"tid\": \"\", \"ts\": \"\"}}");
         out.info("]\n}}");
     }
-    void begin(uint64_t id, const char *fname, std::string args) override {}
+    void begin([[maybe_unused]] uint64_t id, [[maybe_unused]] const char *fname,
+               [[maybe_unused]] std::string args) override {}
 
-    void end(uint64_t id, const char *fname, std::string args, Timepoint tp,
-             Timepoint start_tp, const ur_result_t *resultp) override {
+    void end([[maybe_unused]] uint64_t id, const char *fname, std::string args,
+             Timepoint tp, Timepoint start_tp,
+             [[maybe_unused]] const ur_result_t *resultp) override {
         auto dur = tp - start_tp;
         auto ts_us = std::chrono::duration_cast<std::chrono::microseconds>(
                          tp.time_since_epoch())
@@ -314,10 +316,10 @@ std::optional<fn_context> pop_instance_data(uint64_t instance) {
     return data;
 }
 
-XPTI_CALLBACK_API void trace_cb(uint16_t trace_type,
-                                xpti::trace_event_data_t *parent,
-                                xpti::trace_event_data_t *event,
-                                uint64_t instance, const void *user_data) {
+XPTI_CALLBACK_API void
+trace_cb(uint16_t trace_type, [[maybe_unused]] xpti::trace_event_data_t *parent,
+         [[maybe_unused]] xpti::trace_event_data_t *event, uint64_t instance,
+         const void *user_data) {
     // stop the the clock as the very first thing, only used for TRACE_FN_END
     auto time_for_end = Clock::now();
     auto *args = static_cast<const xpti::function_with_args_t *>(user_data);
@@ -367,7 +369,7 @@ XPTI_CALLBACK_API void trace_cb(uint16_t trace_type,
  */
 XPTI_CALLBACK_API void xptiTraceInit(unsigned int major_version,
                                      unsigned int minor_version,
-                                     const char *version_str,
+                                     [[maybe_unused]] const char *version_str,
                                      const char *stream_name) {
     if (stream_name == nullptr) {
         out.debug("Found stream with null name. Skipping...");