Skip to content

Commit b816fe8

Browse files
authored
Merge pull request #1650 from aarongreig/aaron/fixL0DeviceInfoSizes
Remove the last few bool -> uint32_t conversions from L0 device info.
2 parents 399430d + 092d90e commit b816fe8

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

source/adapters/level_zero/device.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
256256
// > The application must only use the module for the device, or its
257257
// > sub-devices, which was provided during creation.
258258
case UR_DEVICE_INFO_BUILD_ON_SUBDEVICE:
259-
return ReturnValue(uint32_t{0});
259+
return ReturnValue(ur_bool_t{0});
260260
case UR_DEVICE_INFO_COMPILER_AVAILABLE:
261261
return ReturnValue(static_cast<ur_bool_t>(true));
262262
case UR_DEVICE_INFO_LINKER_AVAILABLE:
@@ -326,10 +326,10 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
326326
return ReturnValue(Device->ZeDeviceImageProperties->maxImageDims1D > 0);
327327
case UR_DEVICE_INFO_HOST_UNIFIED_MEMORY:
328328
return ReturnValue(
329-
static_cast<uint32_t>((Device->ZeDeviceProperties->flags &
330-
ZE_DEVICE_PROPERTY_FLAG_INTEGRATED) != 0));
329+
static_cast<ur_bool_t>((Device->ZeDeviceProperties->flags &
330+
ZE_DEVICE_PROPERTY_FLAG_INTEGRATED) != 0));
331331
case UR_DEVICE_INFO_AVAILABLE:
332-
return ReturnValue(static_cast<uint32_t>(ZeDevice ? true : false));
332+
return ReturnValue(static_cast<ur_bool_t>(ZeDevice ? true : false));
333333
case UR_DEVICE_INFO_VENDOR:
334334
// TODO: Level-Zero does not return vendor's name at the moment
335335
// only the ID.
@@ -448,8 +448,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
448448
case UR_DEVICE_INFO_ENDIAN_LITTLE:
449449
return ReturnValue(static_cast<ur_bool_t>(true));
450450
case UR_DEVICE_INFO_ERROR_CORRECTION_SUPPORT:
451-
return ReturnValue(static_cast<uint32_t>(Device->ZeDeviceProperties->flags &
452-
ZE_DEVICE_PROPERTY_FLAG_ECC));
451+
return ReturnValue(static_cast<ur_bool_t>(
452+
Device->ZeDeviceProperties->flags & ZE_DEVICE_PROPERTY_FLAG_ECC));
453453
case UR_DEVICE_INFO_PROFILING_TIMER_RESOLUTION:
454454
return ReturnValue(
455455
static_cast<size_t>(Device->ZeDeviceProperties->timerResolution));
@@ -875,13 +875,13 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
875875
return ReturnValue(static_cast<ur_bool_t>(true));
876876
}
877877
case UR_DEVICE_INFO_TIMESTAMP_RECORDING_SUPPORT_EXP: {
878-
return ReturnValue(static_cast<uint32_t>(true));
878+
return ReturnValue(static_cast<ur_bool_t>(true));
879879
}
880880

881881
case UR_DEVICE_INFO_ESIMD_SUPPORT: {
882882
// ESIMD is only supported by Intel GPUs.
883-
uint32_t result = Device->ZeDeviceProperties->type == ZE_DEVICE_TYPE_GPU &&
884-
Device->ZeDeviceProperties->vendorId == 0x8086;
883+
ur_bool_t result = Device->ZeDeviceProperties->type == ZE_DEVICE_TYPE_GPU &&
884+
Device->ZeDeviceProperties->vendorId == 0x8086;
885885
return ReturnValue(result);
886886
}
887887

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
urDeviceCreateWithNativeHandleTest.SuccessWithUnOwnedNativeHandle
22
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_GLOBAL_MEM_FREE
3-
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ERROR_CORRECTION_SUPPORT
4-
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_HOST_UNIFIED_MEMORY
5-
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_AVAILABLE
63
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_MEMORY_BANDWIDTH
7-
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_BUILD_ON_SUBDEVICE
84
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_ASYNC_BARRIER
95
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_HOST_PIPE_READ_WRITE_SUPPORTED
106
urDeviceGetInfoTest.Success/UR_DEVICE_INFO_MAX_REGISTERS_PER_WORK_GROUP

0 commit comments

Comments
 (0)