Merge pull request #855 from veselypeta/petr/fix-empty-body-warning

pbalcer · web-flow · commit a346a301d776 · 2023-09-13T12:43:47.000+02:00
[UMF] Fix -Wempty-body warning
diff --git a/cmake/helpers.cmake b/cmake/helpers.cmake
@@ -63,6 +63,7 @@ function(add_ur_target_compile_options name)
             -fPIC
             -Wall
             -Wpedantic
+            -Wempty-body
             $<$<CXX_COMPILER_ID:GNU>:-fdiagnostics-color=always>
             $<$<CXX_COMPILER_ID:Clang,AppleClang>:-fcolor-diagnostics>
         )
diff --git a/source/common/unified_malloc_framework/src/utils/utils.h b/source/common/unified_malloc_framework/src/utils/utils.h
@@ -73,9 +73,8 @@ static inline void *Zalloc(size_t s) {
 }
 
 #define NOFUNCTION                                                             \
-    do                                                                         \
-        ;                                                                      \
-    while (0)
+    do {                                                                       \
+    } while (0)
 #define VALGRIND_ANNOTATE_NEW_MEMORY(p, s) NOFUNCTION
 #define VALGRIND_HG_DRD_DISABLE_CHECKING(p, s) NOFUNCTION
 

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ function(add_ur_target_compile_options name)`
`63`	`63`	`-fPIC`
`64`	`64`	`-Wall`
`65`	`65`	`-Wpedantic`
	`66`	`+ -Wempty-body`
`66`	`67`	`$<$<CXX_COMPILER_ID:GNU>:-fdiagnostics-color=always>`
`67`	`68`	`$<$<CXX_COMPILER_ID:Clang,AppleClang>:-fcolor-diagnostics>`
`68`	`69`	`)`