Skip to content

Commit 9d2e9ca

Browse files
authored
Merge pull request #1967 from coldav/colin/improve_set_kernel_arg_value
Improved wording of setKernelArgValue
2 parents 0342c95 + 0866f46 commit 9d2e9ca

File tree

8 files changed

+10
-1
lines changed

8 files changed

+10
-1
lines changed

include/ur_api.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4785,6 +4785,7 @@ urKernelSetArgValue(
47854785
size_t argSize, ///< [in] size of argument type
47864786
const ur_kernel_arg_value_properties_t *pProperties, ///< [in][optional] pointer to value properties.
47874787
const void *pArgValue ///< [in] argument value represented as matching arg type.
4788+
///< The data pointed to will be copied and therefore can be reused on return.
47884789
);
47894790

47904791
///////////////////////////////////////////////////////////////////////////////

scripts/core/kernel.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ params:
6464
desc: "[in][optional] pointer to value properties."
6565
- type: "const void*"
6666
name: pArgValue
67-
desc: "[in] argument value represented as matching arg type."
67+
desc: |
68+
[in] argument value represented as matching arg type.
69+
The data pointed to will be copied and therefore can be reused on return.
6870
returns:
6971
- $X_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX
7072
- $X_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE

source/adapters/mock/ur_mockddi.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3865,6 +3865,7 @@ __urdlllocal ur_result_t UR_APICALL urKernelSetArgValue(
38653865
*pProperties, ///< [in][optional] pointer to value properties.
38663866
const void
38673867
*pArgValue ///< [in] argument value represented as matching arg type.
3868+
///< The data pointed to will be copied and therefore can be reused on return.
38683869
) try {
38693870
ur_result_t result = UR_RESULT_SUCCESS;
38703871

source/loader/layers/tracing/ur_trcddi.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2944,6 +2944,7 @@ __urdlllocal ur_result_t UR_APICALL urKernelSetArgValue(
29442944
*pProperties, ///< [in][optional] pointer to value properties.
29452945
const void
29462946
*pArgValue ///< [in] argument value represented as matching arg type.
2947+
///< The data pointed to will be copied and therefore can be reused on return.
29472948
) {
29482949
auto pfnSetArgValue = getContext()->urDdiTable.Kernel.pfnSetArgValue;
29492950

source/loader/layers/validation/ur_valddi.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3356,6 +3356,7 @@ __urdlllocal ur_result_t UR_APICALL urKernelSetArgValue(
33563356
*pProperties, ///< [in][optional] pointer to value properties.
33573357
const void
33583358
*pArgValue ///< [in] argument value represented as matching arg type.
3359+
///< The data pointed to will be copied and therefore can be reused on return.
33593360
) {
33603361
auto pfnSetArgValue = getContext()->urDdiTable.Kernel.pfnSetArgValue;
33613362

source/loader/ur_ldrddi.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3138,6 +3138,7 @@ __urdlllocal ur_result_t UR_APICALL urKernelSetArgValue(
31383138
*pProperties, ///< [in][optional] pointer to value properties.
31393139
const void
31403140
*pArgValue ///< [in] argument value represented as matching arg type.
3141+
///< The data pointed to will be copied and therefore can be reused on return.
31413142
) {
31423143
ur_result_t result = UR_RESULT_SUCCESS;
31433144

source/loader/ur_libapi.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3647,6 +3647,7 @@ ur_result_t UR_APICALL urKernelSetArgValue(
36473647
*pProperties, ///< [in][optional] pointer to value properties.
36483648
const void
36493649
*pArgValue ///< [in] argument value represented as matching arg type.
3650+
///< The data pointed to will be copied and therefore can be reused on return.
36503651
) try {
36513652
auto pfnSetArgValue =
36523653
ur_lib::getContext()->urDdiTable.Kernel.pfnSetArgValue;

source/ur_api.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3114,6 +3114,7 @@ ur_result_t UR_APICALL urKernelSetArgValue(
31143114
*pProperties, ///< [in][optional] pointer to value properties.
31153115
const void
31163116
*pArgValue ///< [in] argument value represented as matching arg type.
3117+
///< The data pointed to will be copied and therefore can be reused on return.
31173118
) {
31183119
ur_result_t result = UR_RESULT_SUCCESS;
31193120
return result;

0 commit comments

Comments
 (0)