Merge pull request #1973 from omarahmed1111/fix-coverity-issues

Fix some coverity issues

Author: omarahmed1111

source/loader/layers/sanitizer/asan_interceptor.hpp

@@ -43,7 +43,7 @@ struct DeviceInfo {
     uptr ShadowOffsetEnd = 0;
 
     // Device features
-    bool IsSupportSharedSystemUSM;
+    bool IsSupportSharedSystemUSM = false;
 
     ur_mutex Mutex;
     std::queue<std::shared_ptr<AllocInfo>> Quarantine;

source/loader/layers/sanitizer/stacktrace.cpp

@@ -99,7 +99,7 @@ void StackTrace::print() const {
             uptr Offset;
             ParseBacktraceInfo(BI, ModuleName, Offset);
             if (SymbolizeCode(ModuleName, Offset, Result)) {
-                SourceInfo SrcInfo = ParseSymbolizerOutput(Result);
+                SourceInfo SrcInfo = ParseSymbolizerOutput(std::move(Result));
                 if (SrcInfo.file != "??") {
                     getContext()->logger.always(" #{} in {} {}:{}:{}", index,
                                                 SrcInfo.function, SrcInfo.file,

test/layers/validation/fixtures.hpp

@@ -133,7 +133,7 @@ inline ur_result_t genericSuccessCallback(void *) { return UR_RESULT_SUCCESS; };
 // This returns valid (non-null) handles that we can safely leak.
 inline ur_result_t fakeContext_urContextCreate(void *pParams) {
     static std::atomic_int handle = 42;
-    auto params = *static_cast<ur_context_create_params_t *>(pParams);
+    const auto &params = *static_cast<ur_context_create_params_t *>(pParams);
     // There are two casts because windows doesn't implicitly extend the 32 bit
     // result of atomic_int::operator++.
     **params.pphContext =

test/layers/validation/leaks.cpp

@@ -9,7 +9,7 @@
 
 // We need a fake handle for the below adapter leak test.
 inline ur_result_t fakeAdapter_urAdapterGet(void *pParams) {
-    auto params = *static_cast<ur_adapter_get_params_t *>(pParams);
+    const auto &params = *static_cast<ur_adapter_get_params_t *>(pParams);
     **params.pphAdapters = reinterpret_cast<ur_adapter_handle_t>(0x1);
     return UR_RESULT_SUCCESS;
 }

test/loader/handles/fixtures.hpp

@@ -15,7 +15,7 @@
 #endif
 
 ur_result_t replace_urPlatformGet(void *pParams) {
-    auto params = *static_cast<ur_platform_get_params_t *>(pParams);
+    const auto &params = *static_cast<ur_platform_get_params_t *>(pParams);
 
     if (*params.ppNumPlatforms) {
         **params.ppNumPlatforms = 1;
@@ -29,7 +29,7 @@ ur_result_t replace_urPlatformGet(void *pParams) {
 }
 
 ur_result_t replace_urDeviceGetInfo(void *pParams) {
-    auto params = *static_cast<ur_device_get_info_params_t *>(pParams);
+    const auto &params = *static_cast<ur_device_get_info_params_t *>(pParams);
     if (*params.ppropName == UR_DEVICE_INFO_PLATFORM) {
         if (*params.ppPropSizeRet) {
             **params.ppPropSizeRet = sizeof(ur_platform_handle_t);