[UR] Remove parameter names

Author: Petr Vesely

examples/collector/collector.cpp

@@ -82,10 +82,9 @@ static std::unordered_map<
  * On begin, it prints the function declaration with the call arguments specified,
  * and on end it prints the function name with the result of the call.
  */
-XPTI_CALLBACK_API void
-trace_cb(uint16_t trace_type, [[maybe_unused]] xpti::trace_event_data_t *parent,
-         [[maybe_unused]] xpti::trace_event_data_t *event, uint64_t instance,
-         const void *user_data) {
+XPTI_CALLBACK_API void trace_cb(uint16_t trace_type, xpti::trace_event_data_t *,
+                                xpti::trace_event_data_t *, uint64_t instance,
+                                const void *user_data) {
     auto *args = static_cast<const xpti::function_with_args_t *>(user_data);
     std::ostringstream out;
     if (trace_type == TRACE_FN_BEGIN) {
@@ -119,8 +118,7 @@ trace_cb(uint16_t trace_type, [[maybe_unused]] xpti::trace_event_data_t *parent,
  * selected trace types.
  */
 XPTI_CALLBACK_API void xptiTraceInit(unsigned int major_version,
-                                     unsigned int minor_version,
-                                     [[maybe_unused]] const char *version_str,
+                                     unsigned int minor_version, const char *,
                                      const char *stream_name) {
     if (stream_name == nullptr) {
         std::cout << "Stream name not provided. Aborting." << std::endl;
@@ -158,6 +156,5 @@ XPTI_CALLBACK_API void xptiTraceInit(unsigned int major_version,
  *
  * Can be used to cleanup state or resources.
  */
-XPTI_CALLBACK_API void
-xptiTraceFinish([[maybe_unused]] const char *stream_name) { /* noop */
+XPTI_CALLBACK_API void xptiTraceFinish(const char *) { /* noop */
 }

examples/hello_world/hello_world.cpp

@@ -15,7 +15,7 @@
 #include "ur_api.h"
 
 //////////////////////////////////////////////////////////////////////////
-int main([[maybe_unused]] int argc, [[maybe_unused]] char *argv[]) {
+int main(int, char *[]) {
     ur_result_t status;
 
     // Initialize the platform

source/adapters/null/ur_null.cpp

@@ -39,8 +39,7 @@ context_t::context_t() {
     };
     //////////////////////////////////////////////////////////////////////////
     urDdiTable.Platform.pfnGet =
-        []([[maybe_unused]] ur_adapter_handle_t *phAdapters,
-           [[maybe_unused]] uint32_t NumAdapters, uint32_t NumEntries,
+        [](ur_adapter_handle_t *, uint32_t, uint32_t NumEntries,
            ur_platform_handle_t *phPlatforms, uint32_t *pNumPlatforms) {
             if (phPlatforms != nullptr && NumEntries != 1) {
                 return UR_RESULT_ERROR_INVALID_SIZE;
@@ -122,9 +121,8 @@ context_t::context_t() {
 
     //////////////////////////////////////////////////////////////////////////
     urDdiTable.Device.pfnGetInfo =
-        []([[maybe_unused]] ur_device_handle_t hDevice,
-           ur_device_info_t infoType, size_t propSize, void *pDeviceInfo,
-           size_t *pPropSizeRet) {
+        [](ur_device_handle_t, ur_device_info_t infoType, size_t propSize,
+           void *pDeviceInfo, size_t *pPropSizeRet) {
             switch (infoType) {
             case UR_DEVICE_INFO_TYPE:
                 if (pDeviceInfo && propSize != sizeof(ur_device_type_t)) {

source/common/unified_malloc_framework/src/memory_tracker_windows.cpp

@@ -12,11 +12,9 @@
 #include "memory_tracker.h"
 
 #include <windows.h>
-
 #if defined(UMF_SHARED_LIBRARY)
 critnib *TRACKER = NULL;
-BOOL APIENTRY DllMain([[maybe_unused]] HINSTANCE hinstDLL, DWORD fdwReason,
-                      LPVOID lpvReserved) {
+BOOL APIENTRY DllMain(HINSTANCE, DWORD fdwReason, LPVOID lpvReserved) {
     if (fdwReason == DLL_PROCESS_DETACH) {
         critnib_delete(TRACKER);
     } else if (fdwReason == DLL_PROCESS_ATTACH) {

source/loader/ur_lib.cpp

@@ -69,9 +69,8 @@ void context_t::tearDownLayers() const {
 }
 
 //////////////////////////////////////////////////////////////////////////
-__urdlllocal ur_result_t
-context_t::Init([[maybe_unused]] ur_device_init_flags_t device_flags,
-                ur_loader_config_handle_t hLoaderConfig) {
+__urdlllocal ur_result_t context_t::Init(
+    ur_device_init_flags_t, ur_loader_config_handle_t hLoaderConfig) {
     ur_result_t result;
     const char *logger_name = "loader";
     logger::init(logger_name);

test/conformance/event/urEventSetCallback.cpp

@@ -167,9 +167,7 @@ UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urEventSetCallbackTest);
 /* Negative tests */
 using urEventSetCallbackNegativeTest = uur::event::urEventTest;
 
-void emptyCallback([[maybe_unused]] ur_event_handle_t hEvent,
-                   [[maybe_unused]] ur_execution_info_t execStatus,
-                   [[maybe_unused]] void *pUserData) {}
+void emptyCallback(ur_event_handle_t, ur_execution_info_t, void *) {}
 
 TEST_P(urEventSetCallbackNegativeTest, InvalidNullHandleEvent) {
     ASSERT_EQ_RESULT(

test/unified_malloc_framework/memoryPoolAPI.cpp

@@ -233,8 +233,8 @@ TEST_F(test, getLastFailedMemoryProvider) {
             return allocResult;
         }
 
-        enum umf_result_t free(void *ptr, size_t size) noexcept {
-            (void)size;
+        enum umf_result_t free(void *ptr,
+                               [[maybe_unused]] size_t size) noexcept {
             ::free(ptr);
             return UMF_RESULT_SUCCESS;
         }

tools/urtrace/collector.cpp

@@ -245,12 +245,10 @@ class JsonWriter : public TraceWriter {
             "\"tid\": \"\", \"ts\": \"\"}}");
         out.info("]\n}}");
     }
-    void begin([[maybe_unused]] uint64_t id, [[maybe_unused]] const char *fname,
-               [[maybe_unused]] std::string args) override {}
+    void begin(uint64_t, const char *, std::string) override {}
 
-    void end([[maybe_unused]] uint64_t id, const char *fname, std::string args,
-             Timepoint tp, Timepoint start_tp,
-             [[maybe_unused]] const ur_result_t *resultp) override {
+    void end(uint64_t, const char *fname, std::string args, Timepoint tp,
+             Timepoint start_tp, const ur_result_t *) override {
         auto dur = tp - start_tp;
         auto ts_us = std::chrono::duration_cast<std::chrono::microseconds>(
                          tp.time_since_epoch())
@@ -316,10 +314,9 @@ std::optional<fn_context> pop_instance_data(uint64_t instance) {
     return data;
 }
 
-XPTI_CALLBACK_API void
-trace_cb(uint16_t trace_type, [[maybe_unused]] xpti::trace_event_data_t *parent,
-         [[maybe_unused]] xpti::trace_event_data_t *event, uint64_t instance,
-         const void *user_data) {
+XPTI_CALLBACK_API void trace_cb(uint16_t trace_type, xpti::trace_event_data_t *,
+                                xpti::trace_event_data_t *, uint64_t instance,
+                                const void *user_data) {
     // stop the the clock as the very first thing, only used for TRACE_FN_END
     auto time_for_end = Clock::now();
     auto *args = static_cast<const xpti::function_with_args_t *>(user_data);
@@ -368,8 +365,7 @@ trace_cb(uint16_t trace_type, [[maybe_unused]] xpti::trace_event_data_t *parent,
  * Called for every stream.
  */
 XPTI_CALLBACK_API void xptiTraceInit(unsigned int major_version,
-                                     unsigned int minor_version,
-                                     [[maybe_unused]] const char *version_str,
+                                     unsigned int minor_version, const char *,
                                      const char *stream_name) {
     if (stream_name == nullptr) {
         out.debug("Found stream with null name. Skipping...");