[ur] macOS fix dylib version & enable color diagnostics

Update the `MAKE_LIBRARY_NAME` macro to match the library naming scheme
CMake uses when `VERSION` is specified on macOS, taking the form
`lib<name>.<version>.dylib`. Enable color diagnostics for AppleClang.
And disable the `CMAKE_FIND_FRAMEWORK` option so that in-tree dylibs are
correctly loaded.

Author: kbenzie

CMakeLists.txt

@@ -14,6 +14,10 @@ include(CTest)
 list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
 include(helpers)
 
+if(CMAKE_SYSTEM_NAME STREQUAL Darwin)
+  set(CMAKE_FIND_FRAMEWORK NEVER)
+endif()
+
 find_package(Python3 COMPONENTS Interpreter)
 
 set(CMAKE_CXX_STANDARD 17)
@@ -52,7 +56,7 @@ endif()
 if(NOT MSVC)
     add_compile_options(-fPIC -Wall -Wpedantic
         $<$<CXX_COMPILER_ID:GNU>:-fdiagnostics-color=always>
-        $<$<CXX_COMPILER_ID:Clang>:-fcolor-diagnostics>)
+        $<$<CXX_COMPILER_ID:Clang,AppleClang>:-fcolor-diagnostics>)
     if(UR_DEVELOPER_MODE)
         add_compile_options(-Werror -fno-omit-frame-pointer)
     endif()

source/common/ur_util.hpp

@@ -57,8 +57,12 @@ inline int ur_getpid(void) { return static_cast<int>(getpid()); }
 #define MAKE_LIBRARY_NAME(NAME, VERSION) NAME ".dll"
 #else
 #define HMODULE void *
+#if defined(__APPLE__)
+#define MAKE_LIBRARY_NAME(NAME, VERSION) "lib" NAME "." VERSION ".dylib"
+#else
 #define MAKE_LIBRARY_NAME(NAME, VERSION) "lib" NAME ".so." VERSION
 #endif
+#endif
 
 inline std::string create_library_path(const char *name, const char *path) {
     std::string library_path;