Skip to content

Commit 7fd9daf

Browse files
author
Jaime Arteaga
committed
Address comments
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
1 parent 07bac53 commit 7fd9daf

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

source/adapters/level_zero/event.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,11 @@ UR_APIEXPORT ur_result_t UR_APICALL urEnqueueEventsWaitWithBarrier(
165165
// event signal because it is already guaranteed that previous commands
166166
// in this queue are completed when the signal is started.
167167
//
168+
// Only consideration here is that when profiling is used, signalEvent
169+
// cannot be used if EventWaitList.Lenght == 0. In those cases, we need
170+
// to fallback directly to barrier to have correct timestamps. See here:
171+
// https://spec.oneapi.io/level-zero/latest/core/api.html?highlight=appendsignalevent#_CPPv430zeCommandListAppendSignalEvent24ze_command_list_handle_t17ze_event_handle_t
172+
//
168173
// TODO: this and other special handling of in-order queues to be
169174
// updated when/if Level Zero adds native support for in-order queues.
170175
//

0 commit comments

Comments
 (0)