Skip to content

Commit 7344ec4

Browse files
authored
Revert "[HIP] Implement ext_oneapi_queue_priority"
1 parent 46a886d commit 7344ec4

File tree

2 files changed

+7
-22
lines changed

2 files changed

+7
-22
lines changed

source/adapters/hip/queue.cpp

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ hipStream_t ur_queue_handle_t_::getNextComputeStream(uint32_t *StreamToken) {
3838
// The second check is done after mutex is locked so other threads can not
3939
// change NumComputeStreams after that
4040
if (NumComputeStreams < ComputeStreams.size()) {
41-
UR_CHECK_ERROR(hipStreamCreateWithPriority(
42-
&ComputeStreams[NumComputeStreams++], Flags, Priority));
41+
UR_CHECK_ERROR(hipStreamCreateWithFlags(
42+
&ComputeStreams[NumComputeStreams++], Flags));
4343
}
4444
}
4545
Token = ComputeStreamIdx++;
@@ -97,8 +97,8 @@ hipStream_t ur_queue_handle_t_::getNextTransferStream() {
9797
// The second check is done after mutex is locked so other threads can not
9898
// change NumTransferStreams after that
9999
if (NumTransferStreams < TransferStreams.size()) {
100-
UR_CHECK_ERROR(hipStreamCreateWithPriority(
101-
&TransferStreams[NumTransferStreams++], Flags, Priority));
100+
UR_CHECK_ERROR(hipStreamCreateWithFlags(
101+
&TransferStreams[NumTransferStreams++], Flags));
102102
}
103103
}
104104
uint32_t Stream_i = TransferStreamIdx++ % TransferStreams.size();
@@ -118,19 +118,6 @@ urQueueCreate(ur_context_handle_t hContext, ur_device_handle_t hDevice,
118118
std::unique_ptr<ur_queue_handle_t_> QueueImpl{nullptr};
119119

120120
unsigned int Flags = 0;
121-
ur_queue_flags_t URFlags = 0;
122-
int Priority = 0; // Not guaranteed, but, in ROCm 5.7, 0 is the default
123-
124-
if (pProps && pProps->stype == UR_STRUCTURE_TYPE_QUEUE_PROPERTIES) {
125-
URFlags = pProps->flags;
126-
if (URFlags & UR_QUEUE_FLAG_PRIORITY_HIGH) {
127-
ScopedContext Active(hContext->getDevice());
128-
UR_CHECK_ERROR(hipDeviceGetStreamPriorityRange(nullptr, &Priority));
129-
} else if (URFlags & UR_QUEUE_FLAG_PRIORITY_LOW) {
130-
ScopedContext Active(hContext->getDevice());
131-
UR_CHECK_ERROR(hipDeviceGetStreamPriorityRange(&Priority, nullptr));
132-
}
133-
}
134121

135122
const bool IsOutOfOrder =
136123
pProps ? pProps->flags & UR_QUEUE_FLAG_OUT_OF_ORDER_EXEC_MODE_ENABLE
@@ -143,7 +130,7 @@ urQueueCreate(ur_context_handle_t hContext, ur_device_handle_t hDevice,
143130

144131
QueueImpl = std::unique_ptr<ur_queue_handle_t_>(new ur_queue_handle_t_{
145132
std::move(ComputeHipStreams), std::move(TransferHipStreams), hContext,
146-
hDevice, Flags, pProps ? pProps->flags : 0, Priority});
133+
hDevice, Flags, pProps ? pProps->flags : 0});
147134

148135
*phQueue = QueueImpl.release();
149136

@@ -306,7 +293,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urQueueCreateWithNativeHandle(
306293
hDevice,
307294
HIPFlags,
308295
Flags,
309-
/*priority*/ 0,
310296
/*backend_owns*/ pProperties->isNativeHandleOwned};
311297
(*phQueue)->NumComputeStreams = 1;
312298

source/adapters/hip/queue.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ struct ur_queue_handle_t_ {
4444
unsigned int LastSyncTransferStreams;
4545
unsigned int Flags;
4646
ur_queue_flags_t URFlags;
47-
int Priority;
4847
// When ComputeStreamSyncMutex and ComputeStreamMutex both need to be
4948
// locked at the same time, ComputeStreamSyncMutex should be locked first
5049
// to avoid deadlocks
@@ -57,7 +56,7 @@ struct ur_queue_handle_t_ {
5756
ur_queue_handle_t_(std::vector<native_type> &&ComputeStreams,
5857
std::vector<native_type> &&TransferStreams,
5958
ur_context_handle_t Context, ur_device_handle_t Device,
60-
unsigned int Flags, ur_queue_flags_t URFlags, int Priority,
59+
unsigned int Flags, ur_queue_flags_t URFlags,
6160
bool BackendOwns = true)
6261
: ComputeStreams{std::move(ComputeStreams)}, TransferStreams{std::move(
6362
TransferStreams)},
@@ -67,7 +66,7 @@ struct ur_queue_handle_t_ {
6766
Device{Device}, RefCount{1}, EventCount{0}, ComputeStreamIdx{0},
6867
TransferStreamIdx{0}, NumComputeStreams{0}, NumTransferStreams{0},
6968
LastSyncComputeStreams{0}, LastSyncTransferStreams{0}, Flags(Flags),
70-
URFlags(URFlags), Priority(Priority), HasOwnership{BackendOwns} {
69+
URFlags(URFlags), HasOwnership{BackendOwns} {
7170
urContextRetain(Context);
7271
urDeviceRetain(Device);
7372
}

0 commit comments

Comments
 (0)