Skip to content

Commit 6e5d0e6

Browse files
authored
Merge pull request #2428 from igchor/benchmark_unit
[Benchmarks] Fix unit parsing for compute-benchmarks
2 parents 62b2712 + 01499a5 commit 6e5d0e6

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

scripts/benchmarks/benches/compute.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def parse_unit_type(compute_unit):
8686
return "instr"
8787
elif "[us]" in compute_unit:
8888
return "μs"
89-
return "unknown"
89+
return compute_unit.replace("[", "").replace("]", "")
9090

9191
class ComputeBenchmark(Benchmark):
9292
def __init__(self, bench, name, test):
@@ -279,6 +279,10 @@ def __init__(self, bench, type, size, placement):
279279
def name(self):
280280
return f"memory_benchmark_sycl StreamMemory, placement {self.placement}, type {self.type}, size {self.size}"
281281

282+
# measurement is in GB/s
283+
def lower_is_better(self):
284+
return False
285+
282286
def bin_args(self) -> list[str]:
283287
return [
284288
"--iterations=10000",

0 commit comments

Comments
 (0)