Skip to content

Commit 5894231

Browse files
authored
Merge pull request #1658 from npmiller/fix-kernel-crash
[CTS][CUDA][HIP] Skip invalid kernel argument test
2 parents ef2338b + 5e9fdaf commit 5894231

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

test/conformance/enqueue/enqueue_adapter_hip.match

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
{{OPT}}urEnqueueKernelLaunchTest.InvalidKernelArgs/AMD_HIP_BACKEND___{{.*}}_
2+
{{OPT}}urEnqueueKernelLaunchKernelWgSizeTest.NonMatchingLocalSize/AMD_HIP_BACKEND___{{.*}}_
3+
{{OPT}}urEnqueueKernelLaunchKernelSubGroupTest.Success/AMD_HIP_BACKEND___{{.*}}_
14
{{OPT}}urEnqueueKernelLaunchUSMLinkedList.Success/AMD_HIP_BACKEND___{{.*}}___UsePoolEnabled
25
{{OPT}}urEnqueueMemBufferCopyRectTestWithParam.Success/AMD_HIP_BACKEND___{{.*}}___copy_row_2D
36
{{OPT}}urEnqueueMemBufferCopyRectTestWithParam.Success/AMD_HIP_BACKEND___{{.*}}___copy_3d_2d

test/conformance/enqueue/urEnqueueKernelLaunch.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,16 @@ TEST_P(urEnqueueKernelLaunchTest, InvalidWorkGroupSize) {
132132
}
133133

134134
TEST_P(urEnqueueKernelLaunchTest, InvalidKernelArgs) {
135+
ur_platform_backend_t backend;
136+
ASSERT_SUCCESS(urPlatformGetInfo(platform, UR_PLATFORM_INFO_BACKEND,
137+
sizeof(ur_platform_backend_t), &backend,
138+
nullptr));
139+
140+
if (backend == UR_PLATFORM_BACKEND_CUDA ||
141+
backend == UR_PLATFORM_BACKEND_HIP) {
142+
GTEST_FAIL() << "AMD and Nvidia can't check kernel arguments.";
143+
}
144+
135145
// Enqueue kernel without setting any args
136146
ASSERT_EQ_RESULT(urEnqueueKernelLaunch(queue, kernel, n_dimensions,
137147
&global_offset, &global_size,

0 commit comments

Comments
 (0)