Skip to content

Commit 569f4f2

Browse files
committed
[benchmarks] fix umf suite after recent changes
1 parent f9efc51 commit 569f4f2

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/benchmarks-reusable.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,7 @@ jobs:
176176
- name: Build UMF
177177
run: cmake --build ${{github.workspace}}/umf_build -j $(nproc)
178178

179-
- name: Run benchmarks
180-
working-directory: ${{ github.workspace }}/ur-repo/
181-
id: benchmarks
179+
- name: Compute core range
182180
run: |
183181
# Compute the core range for the first NUMA node, skipping the first 4 cores.
184182
# This is to avoid the first cores that the kernel is likely to schedule more work on.
@@ -190,7 +188,13 @@ jobs:
190188
sub(/^0/, "4", b[1])
191189
print b[1]
192190
}')
193-
taskset -c $CORES ${{ github.workspace }}/ur-repo/scripts/benchmarks/main.py
191+
echo "CORES=$CORES" >> $GITHUB_ENV
192+
193+
- name: Run benchmarks
194+
working-directory: ${{ github.workspace }}/ur-repo/
195+
id: benchmarks
196+
run: >
197+
taskset -c ${{ env.CORES }} ${{ github.workspace }}/ur-repo/scripts/benchmarks/main.py
194198
~/bench_workdir
195199
--sycl ${{ github.workspace }}/sycl_build
196200
--ur ${{ github.workspace }}/ur_install

scripts/benchmarks/benches/umf.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ def benchmarks(self) -> list[Benchmark]:
4343

4444
class ComputeUMFBenchmark(Benchmark):
4545
def __init__(self, bench, name):
46+
super().__init__(bench.directory, bench)
47+
4648
self.bench = bench
4749
self.bench_name = name
4850
self.oneapi = get_oneapi()
@@ -55,8 +57,6 @@ def __init__(self, bench, name):
5557

5658
self.col_statistics_time = None
5759

58-
super().__init__(bench.directory)
59-
6060
def bin_args(self) -> list[str]:
6161
return []
6262

0 commit comments

Comments
 (0)