Skip to content

Commit 5480195

Browse files
committed
Address feedback
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
1 parent a9204fd commit 5480195

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

source/adapters/cuda/physical_mem.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urPhysicalMemCreate(
2626
UR_CHECK_ERROR(GetDeviceOrdinal(hDevice, AllocProps.location.id));
2727

2828
CUmemGenericAllocationHandle ResHandle;
29-
UR_CHECK_ERROR(cuMemCreate(&ResHandle, size, &AllocProps, 0));
29+
switch (auto Result = cuMemCreate(&ResHandle, size, &AllocProps, 0)) {
30+
case CUDA_ERROR_INVALID_VALUE:
31+
return UR_RESULT_ERROR_INVALID_SIZE;
32+
default:
33+
UR_CHECK_ERROR(Result);
34+
}
3035
*phPhysicalMem = new ur_physical_mem_handle_t_(ResHandle, hContext);
3136

3237
return UR_RESULT_SUCCESS;

test/conformance/virtual_memory/urPhysicalMemCreate.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ struct urPhysicalMemCreateTest
1616
size_t size;
1717
};
1818

19-
UUR_TEST_SUITE_P(urPhysicalMemCreateTest,
20-
::testing::Values(1, 2, 3, 7, 12, 44, 1024, 4000, 12345),
19+
UUR_TEST_SUITE_P(urPhysicalMemCreateTest, ::testing::Values(1, 2, 3, 7, 12, 44),
2120
uur::deviceTestWithParamPrinter<size_t>);
2221

2322
TEST_P(urPhysicalMemCreateTest, Success) {

test/conformance/virtual_memory/urVirtualMemFree.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ TEST_P(urVirtualMemFreeTest, InvalidNullHandleContext) {
1919

2020
TEST_P(urVirtualMemFreeTest, InvalidNullPointerStart) {
2121
ASSERT_EQ_RESULT(urVirtualMemFree(context, nullptr, size),
22-
UR_RESULT_ERROR_INVALID_NULL_HANDLE);
22+
UR_RESULT_ERROR_INVALID_NULL_POINTER);
2323
}

test/conformance/virtual_memory/urVirtualMemGranularityGetInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ TEST_P(urVirtualMemGranularityGetInfoNegativeTest, InvalidEnumeration) {
6060
context, device,
6161
UR_VIRTUAL_MEM_GRANULARITY_INFO_FORCE_UINT32, 0,
6262
nullptr, &size),
63-
UR_RESULT_ERROR_INVALID_NULL_HANDLE);
63+
UR_RESULT_ERROR_INVALID_ENUMERATION);
6464
}
6565

6666
TEST_P(urVirtualMemGranularityGetInfoNegativeTest,

0 commit comments

Comments
 (0)