Merge pull request #1665 from ldrumm/ref-noref

kbenzie · web-flow · commit 4d7d3ae7d35f · 2024-06-05T14:00:09.000+01:00
Prefer value over reference for `isPowerOf2`
diff --git a/source/ur/ur.hpp b/source/ur/ur.hpp
@@ -337,7 +337,7 @@ roundToHighestFactorOfGlobalSize(size_t &ThreadsPerBlockInDim,
 
 // Returns whether or not Value is a power of 2
 template <typename T, typename = std::enable_if_t<std::is_integral_v<T>>>
-bool isPowerOf2(const T &Value) {
+bool isPowerOf2(const T Value) {
   return Value && !(Value & (Value - 1));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ roundToHighestFactorOfGlobalSize(size_t &ThreadsPerBlockInDim,`
`337`	`337`
`338`	`338`	`// Returns whether or not Value is a power of 2`
`339`	`339`	`template <typename T, typename = std::enable_if_t<std::is_integral_v<T>>>`
`340`		`-bool isPowerOf2(const T &Value) {`
	`340`	`+bool isPowerOf2(const T Value) {`
`341`	`341`	`return Value && !(Value & (Value - 1));`
`342`	`342`	`}`
`343`	`343`