Skip to content

Commit 366bd77

Browse files
authored
Merge pull request #899 from aarongreig/aaron/remainingCLCTSDiff
Another small batch of CTS fixes
2 parents 269626f + d61b8f0 commit 366bd77

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

test/conformance/event/fixtures.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ struct urEventReferenceTest : uur::urProfilingQueueTest {
6565
input.assign(count, 42);
6666
ASSERT_SUCCESS(urEnqueueMemBufferWrite(
6767
queue, buffer, false, 0, size, input.data(), 0, nullptr, &event));
68+
ASSERT_SUCCESS(urEventWait(1, &event));
6869
}
6970

7071
void TearDown() override {

test/conformance/kernel/urKernelCreateWithNativeHandle.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ struct urKernelCreateWithNativeHandleTest : uur::urKernelTest {
2525
ur_kernel_native_properties_t properties = {
2626
UR_STRUCTURE_TYPE_KERNEL_NATIVE_PROPERTIES, /*sType*/
2727
nullptr, /*pNext*/
28-
true /*isNativeHandleOwned*/
28+
false /*isNativeHandleOwned*/
2929
};
3030
};
3131
UUR_INSTANTIATE_KERNEL_TEST_SUITE_P(urKernelCreateWithNativeHandleTest);

test/conformance/queue/urQueueCreateWithNativeHandle.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ TEST_P(urQueueCreateWithNativeHandleTest, Success) {
2323
&properties, &q));
2424
ASSERT_NE(q, nullptr);
2525

26-
uint32_t q_size = 0;
27-
ASSERT_SUCCESS(urQueueGetInfo(q, UR_QUEUE_INFO_SIZE, sizeof(uint32_t),
28-
&q_size, nullptr));
29-
26+
ur_context_handle_t q_context = nullptr;
27+
ASSERT_SUCCESS(urQueueGetInfo(q, UR_QUEUE_INFO_CONTEXT, sizeof(q_context),
28+
&q_context, nullptr));
29+
ASSERT_EQ(q_context, context);
3030
ASSERT_SUCCESS(urQueueRelease(q));
3131
}

test/conformance/queue/urQueueGetInfo.cpp

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,22 @@ UUR_TEST_SUITE_P(urQueueGetInfoTestWithInfoParam,
2929
TEST_P(urQueueGetInfoTestWithInfoParam, Success) {
3030
ur_queue_info_t info_type = getParam();
3131
size_t size = 0;
32-
ASSERT_SUCCESS(urQueueGetInfo(queue, info_type, 0, nullptr, &size));
33-
ASSERT_NE(size, 0);
32+
auto result = urQueueGetInfo(queue, info_type, 0, nullptr, &size);
3433

35-
if (const auto expected_size = queue_info_size_map.find(info_type);
36-
expected_size != queue_info_size_map.end()) {
37-
ASSERT_EQ(expected_size->second, size);
38-
}
34+
if (result == UR_RESULT_SUCCESS) {
35+
ASSERT_NE(size, 0);
36+
37+
if (const auto expected_size = queue_info_size_map.find(info_type);
38+
expected_size != queue_info_size_map.end()) {
39+
ASSERT_EQ(expected_size->second, size);
40+
}
3941

40-
std::vector<uint8_t> data(size);
41-
ASSERT_SUCCESS(
42-
urQueueGetInfo(queue, info_type, size, data.data(), nullptr));
42+
std::vector<uint8_t> data(size);
43+
ASSERT_SUCCESS(
44+
urQueueGetInfo(queue, info_type, size, data.data(), nullptr));
45+
} else {
46+
ASSERT_EQ_RESULT(result, UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION);
47+
}
4348
}
4449

4550
using urQueueGetInfoTest = uur::urQueueTest;

0 commit comments

Comments
 (0)