Skip to content

Commit 34aa5e0

Browse files
committed
Remove command-buffer CTS L0 workaround
The CTS code for command-buffers on the L0 backend has a workaround that forces batched submission to be used rather than immediate submission. However, both batch and immediate submission L0 command-lists are now supported, so this workaround is no longer required. Tested by running on PVC which uses immediate command-lists by default.
1 parent 02ffa90 commit 34aa5e0

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

test/conformance/exp_command_buffer/fixtures.h

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -159,37 +159,17 @@ struct urUpdatableCommandBufferExpExecutionTest
159159
ASSERT_SUCCESS(urCommandBufferCreateExp(context, device, &desc,
160160
&updatable_cmd_buf_handle));
161161
ASSERT_NE(updatable_cmd_buf_handle, nullptr);
162-
163-
// Currently there are synchronization issue with immediate submission when used for command buffers.
164-
// So, create queue with batched submission for this test suite if the backend is Level Zero.
165-
if (backend == UR_PLATFORM_BACKEND_LEVEL_ZERO) {
166-
ur_queue_flags_t flags = UR_QUEUE_FLAG_SUBMISSION_BATCHED;
167-
ur_queue_properties_t props = {
168-
/*.stype =*/UR_STRUCTURE_TYPE_QUEUE_PROPERTIES,
169-
/*.pNext =*/nullptr,
170-
/*.flags =*/flags,
171-
};
172-
ASSERT_SUCCESS(urQueueCreate(context, device, &props, &queue));
173-
ASSERT_NE(queue, nullptr);
174-
} else {
175-
queue = urCommandBufferExpExecutionTest::queue;
176-
}
177162
}
178163

179164
void TearDown() override {
180165
if (updatable_cmd_buf_handle) {
181166
EXPECT_SUCCESS(urCommandBufferReleaseExp(updatable_cmd_buf_handle));
182167
}
183-
if (backend == UR_PLATFORM_BACKEND_LEVEL_ZERO && queue) {
184-
ASSERT_SUCCESS(urQueueRelease(queue));
185-
}
186-
187168
UUR_RETURN_ON_FATAL_FAILURE(
188169
urCommandBufferExpExecutionTest::TearDown());
189170
}
190171

191172
ur_exp_command_buffer_handle_t updatable_cmd_buf_handle = nullptr;
192-
ur_queue_handle_t queue = nullptr;
193173
};
194174

195175
struct urCommandBufferCommandExpTest

0 commit comments

Comments
 (0)