Skip to content

Commit cf64635

Browse files
committed
Add utils_env_var_get_str() to utils_common
Add utils_env_var_get_str() to utils_common. Use utils_env_var_get_str() inside utils_env_var_has_str() and utils_is_running_in_proxy_lib(). Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
1 parent c99b876 commit cf64635

File tree

2 files changed

+13
-15
lines changed

2 files changed

+13
-15
lines changed

src/utils/utils_common.c

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,18 +53,9 @@ void utils_align_ptr_down_size_up(void **ptr, size_t *size, size_t alignment) {
5353
*size = s;
5454
}
5555

56-
int utils_env_var_has_str(const char *envvar, const char *str) {
56+
char *utils_env_var_get_str(const char *envvar, const char *str) {
5757
char *value = getenv(envvar);
58-
if (value && strstr(value, str)) {
59-
return 1;
60-
}
61-
62-
return 0;
63-
}
64-
65-
// check if we are running in the proxy library
66-
int utils_is_running_in_proxy_lib(void) {
67-
return utils_env_var_has_str("LD_PRELOAD", "libumf_proxy.so");
58+
return value ? strstr(value, str) : NULL;
6859
}
6960

7061
const char *utils_parse_var(const char *var, const char *option,

src/utils/utils_common.h

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,18 @@ typedef enum umf_purge_advise_t {
6262

6363
#endif /* _WIN32 */
6464

65+
// get the address of the given string in the environment variable (or NULL)
66+
char *utils_env_var_get_str(const char *envvar, const char *str);
67+
6568
// Check if the environment variable contains the given string.
66-
int utils_env_var_has_str(const char *envvar, const char *str);
69+
static inline int utils_env_var_has_str(const char *envvar, const char *str) {
70+
return utils_env_var_get_str(envvar, str) ? 1 : 0;
71+
}
72+
73+
// check if we are running in the proxy library
74+
static inline int utils_is_running_in_proxy_lib(void) {
75+
return utils_env_var_get_str("LD_PRELOAD", "libumf_proxy.so") ? 1 : 0;
76+
}
6777

6878
// utils_parse_var - Parses var for a prefix,
6979
// optionally identifying a following argument.
@@ -82,9 +92,6 @@ int utils_env_var_has_str(const char *envvar, const char *str);
8292
const char *utils_parse_var(const char *var, const char *option,
8393
const char **extraArg);
8494

85-
// check if we are running in the proxy library
86-
int utils_is_running_in_proxy_lib(void);
87-
8895
size_t utils_get_page_size(void);
8996

9097
// align a pointer up and a size down

0 commit comments

Comments
 (0)