Skip to content

Commit 89c2f7a

Browse files
[Tests] clean multi numa tests up
1 parent f31f7b0 commit 89c2f7a

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

test/provider_os_memory_multiple_numa_nodes.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44

55
#include "base.hpp"
66
#include "numa_helpers.h"
7+
#include "test_helpers.h"
78

89
#include <numa.h>
910
#include <numaif.h>
1011
#include <sched.h>
1112

12-
#include "test_helpers.h"
1313
#include <umf/providers/provider_os_memory.h>
1414

1515
static umf_os_memory_provider_params_t UMF_OS_MEMORY_PROVIDER_PARAMS_TEST =
@@ -138,7 +138,6 @@ TEST_P(testNumaOnEachNode, checkNumaNodesAllocations) {
138138
UMF_OS_MEMORY_PROVIDER_PARAMS_TEST;
139139

140140
os_memory_provider_params.numa_list = &numa_node_number;
141-
numa_bitmask_setbit(nodemask, numa_node_number);
142141
os_memory_provider_params.numa_list_len = 1;
143142
os_memory_provider_params.numa_mode = UMF_NUMA_MODE_BIND;
144143
initOsProvider(os_memory_provider_params);
@@ -216,7 +215,6 @@ TEST_P(testNumaOnEachNode, checkModeInterleaveSingleNode) {
216215
UMF_OS_MEMORY_PROVIDER_PARAMS_TEST;
217216

218217
os_memory_provider_params.numa_list = &numa_node_number;
219-
numa_bitmask_setbit(nodemask, numa_node_number);
220218
os_memory_provider_params.numa_list_len = 1;
221219
os_memory_provider_params.numa_mode = UMF_NUMA_MODE_INTERLEAVE;
222220
initOsProvider(os_memory_provider_params);
@@ -335,7 +333,7 @@ TEST_F(testNuma, checkModeDefault) {
335333
}
336334

337335
// Test for allocations on numa nodes with interleave mode enabled.
338-
// The page allocations are interleaved across the set of nodes specified in nodemask.
336+
// The page allocations are interleaved across the set of all available nodes.
339337
TEST_F(testNuma, checkModeInterleave) {
340338
constexpr int pages_num = 1024;
341339
size_t page_size = sysconf(_SC_PAGE_SIZE);

0 commit comments

Comments
 (0)