Skip to content

Commit 653d220

Browse files
committed
Drop unnecessary code
1 parent 7ac2d2c commit 653d220

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

src/memory_pool.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static int CTL_SUBTREE_HANDLER(default)(void *ctx,
5454
umf_ctl_index_utlist_t *indexes,
5555
const char *extra_name,
5656
umf_ctl_query_type_t queryType) {
57-
(void)indexes, (void)source, (void)ctx;
57+
(void)indexes, (void)source;
5858
utils_init_once(&mem_pool_ctl_initialized, ctl_init);
5959
utils_mutex_lock(&ctl_mtx);
6060

@@ -93,6 +93,7 @@ static int CTL_SUBTREE_HANDLER(default)(void *ctx,
9393
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
9494
}
9595
}
96+
9697
utils_mutex_unlock(&ctl_mtx);
9798
return 0;
9899
}

src/pool/pool_disjoint.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ static int CTL_READ_HANDLER(name)(void *ctx, umf_ctl_query_source_t source,
3636
umf_ctl_index_utlist_t *indexes,
3737
const char *extra_name,
3838
umf_ctl_query_type_t queryType) {
39-
(void)source, (void)indexes, (void)queryType, (void)size, (void)extra_name;
39+
(void)source, (void)indexes, (void)queryType, (void)extra_name;
4040
disjoint_pool_t *pool = (disjoint_pool_t *)ctx;
4141

4242
if (arg == NULL) {

test/ctl/ctl_api.cpp

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -196,18 +196,6 @@ class CtlTest : public ::testing::Test {
196196
private:
197197
};
198198

199-
TEST_F(CtlTest, ctlDefaultNegative) {
200-
void *ctx = (void *)0xBABE;
201-
void *arg = (void *)0xBABE;
202-
203-
// Test invalid path for umfCtlGet and umfCtlSet
204-
auto res = umfCtlGet("umf.pool.default.disjoint.some_path", ctx, arg, 0);
205-
ASSERT_EQ(res, UMF_RESULT_ERROR_INVALID_ARGUMENT);
206-
207-
res = umfCtlSet("umf.pool.default.disjoint.some_path", ctx, arg, 0);
208-
ASSERT_EQ(res, UMF_RESULT_ERROR_INVALID_ARGUMENT);
209-
}
210-
211199
/* Case: default settings
212200
* This test sets a default value and then retrieves it */
213201
TEST_F(CtlTest, ctlDefault) {

0 commit comments

Comments
 (0)