Merge pull request #1363 from KFilipek/umfctlexec-size-check

[CTL] Add size check for umfCtlExec

Author: lukaszstolarczuk

src/libumf.c

@@ -128,6 +128,10 @@ umf_result_t umfCtlExec(const char *name, void *ctx, void *arg, size_t size) {
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;
     }
 
+    if ((arg == NULL && size != 0) || (arg != NULL && size == 0)) {
+        return UMF_RESULT_ERROR_INVALID_ARGUMENT;
+    }
+
     return ctl_query(NULL, ctx, CTL_QUERY_PROGRAMMATIC, name,
                      CTL_QUERY_RUNNABLE, arg, size)
                ? UMF_RESULT_ERROR_UNKNOWN

test/ctl/ctl_api.cpp

@@ -351,6 +351,14 @@ TEST_F(CtlTest, ctlSizeValidation) {
     p.freeResources();
 }
 
+TEST_F(CtlTest, ctlExecInvalidSize) {
+    std::string name = "umf.pool.default.disjoint.name";
+    ASSERT_EQ(umfCtlSet(name.c_str(), NULL, (void *)"test_value", 0),
+              UMF_RESULT_ERROR_INVALID_ARGUMENT);
+    ASSERT_EQ(umfCtlSet(name.c_str(), NULL, NULL, 10),
+              UMF_RESULT_ERROR_INVALID_ARGUMENT);
+}
+
 #ifdef PROVIDER_DEFAULTS_NOT_IMPLEMENTED_YET
 TEST_F(CtlTest, ctlDefaultMultithreadedProvider) {
     std::vector<std::thread> threads;