Skip to content

Commit 5c65861

Browse files
committed
Do not assert(ptr) in umfMemoryTrackerGetAllocInfo()
Do not assert(ptr) in umfMemoryTrackerGetAllocInfo(), return UMF_RESULT_ERROR_INVALID_ARGUMENT instead. Replace LOG_WARN() with LOG_DEBUG().
1 parent 76c8ebf commit 5c65861

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/provider/provider_tracking.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,19 @@ umf_memory_pool_handle_t umfMemoryTrackerGetPool(const void *ptr) {
103103

104104
umf_result_t umfMemoryTrackerGetAllocInfo(const void *ptr,
105105
umf_alloc_info_t *pAllocInfo) {
106-
assert(ptr);
107106
assert(pAllocInfo);
108107

108+
if (ptr == NULL) {
109+
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
110+
}
111+
109112
if (TRACKER == NULL) {
110-
LOG_ERR("tracker is not created");
113+
LOG_ERR("tracker does not exist");
111114
return UMF_RESULT_ERROR_NOT_SUPPORTED;
112115
}
113116

114117
if (TRACKER->map == NULL) {
115-
LOG_ERR("tracker's map is not created");
118+
LOG_ERR("tracker's map does not exist");
116119
return UMF_RESULT_ERROR_NOT_SUPPORTED;
117120
}
118121

@@ -121,9 +124,8 @@ umf_result_t umfMemoryTrackerGetAllocInfo(const void *ptr,
121124
int found = critnib_find(TRACKER->map, (uintptr_t)ptr, FIND_LE,
122125
(void *)&rkey, (void **)&rvalue);
123126
if (!found || (uintptr_t)ptr >= rkey + rvalue->size) {
124-
LOG_WARN("pointer %p not found in the "
125-
"tracker, TRACKER=%p",
126-
ptr, (void *)TRACKER);
127+
LOG_DEBUG("pointer %p not found in the tracker, TRACKER=%p", ptr,
128+
(void *)TRACKER);
127129
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
128130
}
129131

0 commit comments

Comments
 (0)