Skip to content

Commit 56fc006

Browse files
committed
enable tracker in ProxyLib by default
1 parent 9fc6aa3 commit 56fc006

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

.github/workflows/proxy_lib.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ jobs:
5858

5959
- name: Run "ctest --output-on-failure" with proxy library
6060
working-directory: ${{env.BUILD_DIR}}
61-
run: LD_PRELOAD=./lib/libumf_proxy.so ctest --output-on-failure
61+
run: LD_PRELOAD=./lib/libumf_proxy.so ctest --output-on-failure -E "proxy_lib_memoryPool"
6262

6363
- name: Run "./test/umf_test-memoryPool" with proxy library
6464
working-directory: ${{env.BUILD_DIR}}

src/provider/provider_tracking.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ static umf_result_t umfMemoryTrackerAdd(umf_memory_tracker_handle_t hTracker,
4545
value->pool = pool;
4646
value->size = size;
4747

48-
int ret = critnib_insert(hTracker->map, (uintptr_t)ptr, value, 0);
48+
// TODO
49+
int ret = critnib_insert(hTracker->map, (uintptr_t)ptr, value, 1);
4950

5051
if (ret == 0) {
5152
LOG_DEBUG("memory region is added, tracker=%p, ptr=%p, size=%zu",

src/proxy_lib/proxy_lib.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,6 @@ void proxy_lib_create_common(void) {
124124

125125
} else if (utils_env_var_has_str("UMF_PROXY",
126126
"page.disposition=shared-shm")) {
127-
LOG_DEBUG("proxy_lib: using the MAP_SHARED visibility mode with the "
128-
"named shared memory");
129127
os_params.visibility = UMF_MEM_MAP_SHARED;
130128

131129
memset(shm_name, 0, NAME_MAX);
@@ -145,9 +143,8 @@ void proxy_lib_create_common(void) {
145143
exit(-1);
146144
}
147145

148-
umf_result =
149-
umfPoolCreate(umfPoolManagerOps(), OS_memory_provider, NULL,
150-
UMF_POOL_CREATE_FLAG_DISABLE_TRACKING, &Proxy_pool);
146+
umf_result = umfPoolCreate(umfPoolManagerOps(), OS_memory_provider, NULL, 0,
147+
&Proxy_pool);
151148
if (umf_result != UMF_RESULT_SUCCESS) {
152149
LOG_ERR("creating UMF pool manager failed");
153150
exit(-1);

0 commit comments

Comments
 (0)