Merge pull request #97 from rafbiels/lc0-segfault

jgtong · web-flow · commit 2b1479123ea3 · 2025-05-08T09:31:27.000-07:00
[lc0][SYCL] Fix segfault
diff --git a/lc0/src/neural/sycl/layers.cc.dp.cpp b/lc0/src/neural/sycl/layers.cc.dp.cpp
@@ -1681,7 +1681,7 @@ void allocAndUpload(DataType** gpu_dest, std::vector<float> cpu_src,
     return;
   }
   
-  gpu_dest = (DataType **)sycl::malloc_device(size, sycl_queue);
+  *gpu_dest = sycl::malloc_device<DataType>(cpu_src.size(), sycl_queue);
 
   //sycl_queue.memcpy(scratch, &cpu_src[0], cpu_src.size() * sizeof(float)).wait();
   sycl_queue.memcpy(scratch, &cpu_src[0], cpu_src.size() * sizeof(float)).wait();

Original file line number	Diff line number	Diff line change
`@@ -1681,7 +1681,7 @@ void allocAndUpload(DataType** gpu_dest, std::vector<float> cpu_src,`
`1681`	`1681`	`return;`
`1682`	`1682`	`}`
`1683`	`1683`
`1684`		`- gpu_dest = (DataType **)sycl::malloc_device(size, sycl_queue);`
	`1684`	`+ *gpu_dest = sycl::malloc_device<DataType>(cpu_src.size(), sycl_queue);`
`1685`	`1685`
`1686`	`1686`	`//sycl_queue.memcpy(scratch, &cpu_src[0], cpu_src.size() * sizeof(float)).wait();`
`1687`	`1687`	`sycl_queue.memcpy(scratch, &cpu_src[0], cpu_src.size() * sizeof(float)).wait();`