Skip to content

Commit dec64d6

Browse files
authored
[SYCLomatic] Fix the migration of __hfma (#2710)
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
1 parent 46798de commit dec64d6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

clang/lib/DPCT/RulesLang/Math/RewriterHalfArithmeticFunctions.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ RewriterMap dpct::createHalfArithmeticFunctionsRewriterMap() {
115115
CALL_FACTORY_ENTRY("__hfma",
116116
CALL(MapNames::getClNamespace() +
117117
"ext::intel::math::hfma",
118-
ARG(0), ARG(1)))),
118+
ARG(0), ARG(1), ARG(2)))),
119119
EMPTY_FACTORY_ENTRY("__hfma"),
120120
CALL_FACTORY_ENTRY(
121121
"__hfma",

clang/test/dpct/query_api_mapping/Math/test-after11.cu

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
// HFMA-NEXT: __hfma(h1 /*__half*/, h2 /*__half*/, h3 /*__half*/);
4343
// HFMA-NEXT: __hfma(b1 /*__nv_bfloat16*/, b2 /*__nv_bfloat16*/, b3 /*__nv_bfloat16*/);
4444
// HFMA-NEXT: Is migrated to (with the option --use-dpcpp-extensions=intel_device_math --use-experimental-features=bfloat16_math_functions):
45-
// HFMA-NEXT: sycl::ext::intel::math::hfma(h1, h2);
45+
// HFMA-NEXT: sycl::ext::intel::math::hfma(h1, h2, h3);
4646
// HFMA-NEXT: sycl::ext::oneapi::experimental::fma(b1, b2, b3);
4747

4848
// RUN: dpct --cuda-include-path="%cuda-path/include" --query-api-mapping=__hfma_relu | FileCheck %s -check-prefix=HFMA_RELU

clang/test/dpct/query_api_mapping/test.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// CHECK-NEXT: __hfma(h1 /*__half*/, h2 /*__half*/, h3 /*__half*/);
2222
// CHECK-NEXT: __hfma(b1 /*__nv_bfloat16*/, b2 /*__nv_bfloat16*/, b3 /*__nv_bfloat16*/);
2323
// CHECK-NEXT: Is migrated to (with the option --use-dpcpp-extensions=intel_device_math --use-experimental-features=bfloat16_math_functions):
24-
// CHECK-NEXT: sycl::ext::intel::math::hfma(h1, h2);
24+
// CHECK-NEXT: sycl::ext::intel::math::hfma(h1, h2, h3);
2525
// CHECK-NEXT: sycl::ext::oneapi::experimental::fma(b1, b2, b3);
2626

2727
// RUN: dpct --cuda-include-path="%cuda-path/include" --use-syclcompat --query-api-mapping=cudaMallocPitch | FileCheck %s -check-prefix=SYCLCOMPAT
@@ -52,7 +52,7 @@
5252
// MULTI_QUERY-NEXT: __hfma(h1 /*__half*/, h2 /*__half*/, h3 /*__half*/);
5353
// MULTI_QUERY-NEXT: __hfma(b1 /*__nv_bfloat16*/, b2 /*__nv_bfloat16*/, b3 /*__nv_bfloat16*/);
5454
// MULTI_QUERY-NEXT: Is migrated to (with the option --use-dpcpp-extensions=intel_device_math --use-experimental-features=bfloat16_math_functions):
55-
// MULTI_QUERY-NEXT: sycl::ext::intel::math::hfma(h1, h2);
55+
// MULTI_QUERY-NEXT: sycl::ext::intel::math::hfma(h1, h2, h3);
5656
// MULTI_QUERY-NEXT: sycl::ext::oneapi::experimental::fma(b1, b2, b3);
5757

5858
// RUN: dpct --cuda-include-path="%cuda-path/include" --query-api-mapping=cudaMalloc --usm-level=none 2>&1 | FileCheck %s -check-prefix=CONFLICT_OPT

0 commit comments

Comments
 (0)