Add tests

Author: jmarin

api-model/src/main/scala/hmda/api/protocol/public/ULIProtocol.scala

@@ -3,7 +3,7 @@ package hmda.api.protocol.public
 import hmda.api.model.public.ULIModel.{ Loan, ULI, ULICheck, ULIValidated }
 import spray.json.DefaultJsonProtocol
 
-object ULIProtocol extends DefaultJsonProtocol {
+trait ULIProtocol extends DefaultJsonProtocol {
 
   implicit val loanFormat = jsonFormat1(Loan.apply)
   implicit val uliFormat = jsonFormat3(ULI.apply)

api/src/main/scala/hmda/api/http/public/PublicHttpApi.scala

@@ -7,14 +7,14 @@ import akka.util.Timeout
 import hmda.api.http.HmdaCustomDirectives
 import akka.http.scaladsl.server.Directives._
 import hmda.api.model.public.ULIModel.{ Loan, ULI, ULICheck, ULIValidated }
-import hmda.api.protocol.public.ULIProtocol._
 import hmda.validation.engine.lar.ULI._
 import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._
 import akka.http.scaladsl.marshalling.ToResponseMarshallable
+import hmda.api.protocol.public.ULIProtocol
 
 import scala.concurrent.ExecutionContext
 
-trait PublicHttpApi extends PublicLarHttpApi with HmdaCustomDirectives {
+trait PublicHttpApi extends PublicLarHttpApi with HmdaCustomDirectives with ULIProtocol {
   implicit val system: ActorSystem
   implicit val materializer: ActorMaterializer
   implicit val timeout: Timeout

api/src/test/scala/hmda/api/http/public/PublicHttpApiSpec.scala

@@ -5,14 +5,17 @@ import akka.http.scaladsl.model.StatusCodes
 import akka.http.scaladsl.testkit.ScalatestRouteTest
 import akka.util.Timeout
 import hmda.api.RequestHeaderUtils
+import hmda.api.model.public.ULIModel.{ Loan, ULI, ULICheck, ULIValidated }
+import hmda.api.protocol.public.ULIProtocol
 import hmda.model.fi.lar.LarGenerators
 import hmda.query.repository.filing.LarConverter._
 import org.scalatest.{ BeforeAndAfterAll, MustMatchers, WordSpec }
+import akka.http.scaladsl.marshallers.sprayjson.SprayJsonSupport._
 
 import scala.concurrent.duration._
 
 class PublicHttpApiSpec extends WordSpec with MustMatchers with BeforeAndAfterAll
-    with ScalatestRouteTest with RequestHeaderUtils with PublicHttpApi with LarGenerators {
+    with ScalatestRouteTest with RequestHeaderUtils with PublicHttpApi with LarGenerators with ULIProtocol {
 
   override val log: LoggingAdapter = NoLogging
   implicit val ec = system.dispatcher
@@ -35,4 +38,23 @@ class PublicHttpApiSpec extends WordSpec with MustMatchers with BeforeAndAfterAl
     }
   }
 
+  "ULI API" must {
+    val loanId = "10Bx939c5543TqA1144M999143X"
+    val checkDigit = 38
+    val uli = "10Bx939c5543TqA1144M999143X" + checkDigit
+    val loan = Loan(loanId)
+    val uliCheck = ULICheck(uli)
+
+    "return check digit and ULI from loan id" in {
+      Post("/uli/check-digit", loan) ~> publicHttpRoutes ~> check {
+        responseAs[ULI] mustBe ULI(loanId, checkDigit, uli)
+      }
+    }
+    "Validate ULI" in {
+      Post("/uli/validate", uliCheck) ~> publicHttpRoutes ~> check {
+        responseAs[ULIValidated] mustBe ULIValidated(true)
+      }
+    }
+  }
+
 }