Skip to content

Commit 4c1e39b

Browse files
authored
Merge pull request cfpb#1161 from nickgrippin/javamail
Remove JavaMail dependency and email methods
2 parents a999d2f + 7bec83d commit 4c1e39b

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

api/src/main/scala/hmda/api/http/institutions/submissions/SubmissionSignPaths.scala

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package hmda.api.http.institutions.submissions
22

3-
import java.time.{ ZoneOffset, ZonedDateTime }
4-
53
import akka.actor.{ ActorRef, ActorSystem }
64
import akka.event.LoggingAdapter
75
import akka.pattern.ask
@@ -20,19 +18,20 @@ import hmda.persistence.HmdaSupervisor.{ FindProcessingActor, FindSubmissions }
2018
import hmda.persistence.institutions.SubmissionPersistence
2119
import hmda.persistence.institutions.SubmissionPersistence.GetSubmissionById
2220
import hmda.persistence.processing.SubmissionManager
21+
import hmda.query.repository.KeyCloakRepository
2322
import spray.json.{ JsBoolean, JsFalse, JsObject, JsTrue }
2423

2524
import scala.util.{ Failure, Success }
2625
import scala.concurrent.{ ExecutionContext, Future }
27-
import javax.mail._
26+
/*import javax.mail._
2827
import javax.mail.internet.{ InternetAddress, MimeMessage }
2928
3029
import com.typesafe.config.ConfigFactory
3130
import hmda.model.institution.Institution
3231
import hmda.persistence.model.HmdaSupervisorActor.FindActorByName
33-
import hmda.query.repository.KeyCloakRepository
3432
import hmda.query.view.institutions.InstitutionView
3533
import hmda.query.view.institutions.InstitutionView.GetInstitutionById
34+
import java.time.{ ZoneOffset, ZonedDateTime }*/
3635

3736
trait SubmissionSignPaths
3837
extends InstitutionProtocol
@@ -97,15 +96,13 @@ trait SubmissionSignPaths
9796

9897
onComplete(fSubmission) {
9998
case Success(sub) =>
100-
if (signed) {
101-
emailSignature(supervisor, sub)
102-
}
99+
//if (signed) emailSignature(supervisor, sub)
103100
complete(ToResponseMarshallable(Receipt(sub.end, sub.receipt, sub.status)))
104101
case Failure(error) => completeWithInternalError(uri, error)
105102
}
106103
}
107104

108-
private def emailSignature(supervisor: ActorRef, submission: Submission)(implicit ec: ExecutionContext) = {
105+
/*private def emailSignature(supervisor: ActorRef, submission: Submission)(implicit ec: ExecutionContext) = {
109106
val emails = findEmailsById(submission.id.institutionId)
110107
val querySupervisor = system.actorSelection("/user/query-supervisor/singleton")
111108
val fInstitutionsActor = (querySupervisor ? FindActorByName(InstitutionView.name)).mapTo[ActorRef]
@@ -161,5 +158,5 @@ trait SubmissionSignPaths
161158
val year = zonedTime.getYear
162159
163160
s"$month/$day/$year"
164-
}
161+
}*/
165162
}

build.sbt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ lazy val api = (project in file("api"))
211211
oldStrategy(x)
212212
},
213213
parallelExecution in Test := false,
214-
libraryDependencies ++= httpDeps ++ Seq(javaMail)
214+
libraryDependencies ++= httpDeps
215+
//++ Seq(javaMail)
215216
)
216217
)
217218
.dependsOn(persistenceModel % "compile->compile;test->test")

0 commit comments

Comments
 (0)