Skip to content

Commit bb42881

Browse files
committed
👷 Add JRuby back to CI (v)
1 parent 108f024 commit bb42881

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

.github/workflows/current.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484

8585
# jruby-10.0 (targets Ruby 3.4 compatibility)
8686
- ruby: "jruby"
87-
appraisal: "ar-8-0"
87+
appraisal: "ar-7-2"
8888
exec_cmd: "rake spec:orm:active_record"
8989
gemfile: "Appraisal.root"
9090
rubygems: default

.github/workflows/heads.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555

5656
# jruby-head
5757
- ruby: "jruby-head"
58-
appraisal: "ar-8-0"
58+
appraisal: "ar-7-2"
5959
exec_cmd: "rake spec:orm:active_record"
6060
gemfile: "Appraisal.root"
6161
rubygems: default

Appraisals

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,16 @@ appraise "ar-8-0" do
110110
gem "mutex_m", "~> 0.2"
111111
gem "stringio", "~> 3.0"
112112
gem "sqlite3", ">= 1.7", platforms: [:ruby]
113-
platforms :jruby do
114-
# gem "jdbc-sqlite3", github: "jruby/activerecord-jdbc-adapter", branch: "master"
115-
# gem "jdbc-mysql", github: "jruby/activerecord-jdbc-adapter", branch: "master"
116-
# gem "jdbc-postgres", github: "jruby/activerecord-jdbc-adapter", branch: "master"
117-
gem "activerecord-jdbc-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
118-
gem "activerecord-jdbcsqlite3-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
119-
# gem "activerecord-jdbcmysql-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
120-
# gem "activerecord-jdbcpostgresql-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
121-
end
113+
# NOTE: JRuby is not yet compatible with Rails 8 (or vice versa)
114+
# platforms :jruby do
115+
# # gem "jdbc-sqlite3", github: "jruby/activerecord-jdbc-adapter", branch: "master"
116+
# # gem "jdbc-mysql", github: "jruby/activerecord-jdbc-adapter", branch: "master"
117+
# # gem "jdbc-postgres", github: "jruby/activerecord-jdbc-adapter", branch: "master"
118+
# gem "activerecord-jdbc-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
119+
# gem "activerecord-jdbcsqlite3-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
120+
# # gem "activerecord-jdbcmysql-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
121+
# # gem "activerecord-jdbcpostgresql-adapter", github: "jruby/activerecord-jdbc-adapter", branch: "master"
122+
# end
122123
end
123124

124125
# Compat: Ruby >= 2.2.2 (due to AR >= 5)

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ Please upvote the PR for `eval_gemfile` [support][🚎appraisal-eval-gemfile-pr]
4949
```shell
5050
BUNDLE_GEMFILE=Appraisal.root.gemfile bundle
5151
BUNDLE_GEMFILE=Appraisal.root.gemfile bundle exec appraisal update
52+
bundle exec rake rubocop_gradual:autocorrect
5253
```
5354

5455
When adding an appraisal to CI check the [runner tool cache][🏃‍♂️runner-tool-cache] to see which runner to use.

0 commit comments

Comments
 (0)