Fix: The classmap could point to a file

Author: olvlvl

src/MemoizeClassMapGenerator.php

@@ -10,6 +10,7 @@
 use function array_filter;
 use function array_merge;
 use function filemtime;
+use function is_dir;
 use function is_int;
 use function time;
 
@@ -119,6 +120,11 @@ private function should_update(int $timestamp, string $path): bool
             return true;
         }
 
+        // Could be a file referenced as class map, we don't want to iterate over that.
+        if (!is_dir($path)) {
+            return false;
+        }
+
         foreach (new DirectoryIterator($path) as $di) {
             if ($di->isDir() && !$di->isDot()) {
                 if ($this->should_update($timestamp, $di->getPathname())) {

tests/MemoizeClassMapGeneratorTest.php

@@ -35,7 +35,7 @@ protected function setUp(): void
 
     public function testMemoize(): void
     {
-        $map = $this->map();
+        $map = $this->map(self::DIR);
         $this->assertEmpty($map);
 
         // check changes in the directory are detected
@@ -52,7 +52,13 @@ class A {
             PHP
         );
 
-        $map = $this->map();
+        $map = $this->map(self::DIR . 'a.php');
+        $this->assertEquals([
+            'App\A' => self::DIR . 'a.php',
+        ], $map);
+
+        // map again to test the code is not trying to iterate over the file like it's a directory
+        $map = $this->map(self::DIR . 'a.php');
         $this->assertEquals([
             'App\A' => self::DIR . 'a.php',
         ], $map);
@@ -71,7 +77,7 @@ class B {
             PHP
         );
 
-        $map = $this->map();
+        $map = $this->map(self::DIR);
         $this->assertEquals([
             'App\A' => self::DIR . 'a.php',
             'App\B' => self::DIR . 'a/b/c/b.php',
@@ -90,14 +96,14 @@ private static function write(string $name, string $data): void
     /**
      * @return array<class-string, string>
      */
-    private static function map(): array
+    private static function map(string $path): array
     {
         $generator = new MemoizeClassMapGenerator(
             new FileDatastore(get_cache_dir()),
             new NullIO(),
         );
 
-        $generator->scanPaths(self::DIR);
+        $generator->scanPaths($path);
 
         return $generator->getMap();
     }