Change logic toCollect method

Author: Olek Kaim

src/Dto/SearchResponseDto.php

@@ -47,19 +47,13 @@ public function toArray(): array
         ];
     }
 
-    public function toCollect(bool $asArray = false): Collection
+    public function toCollect(): Collection
     {
-        $hitsCollection = $this->getResult()->getHits();
+        $hits = array_map(
+            fn(SearchHitDto $searchHitDto) => $searchHitDto->getSource(),
+            $this->getResult()->getHits()
+        );
 
-        if ($asArray) {
-            $hits = array_map(
-                fn(SearchHitDto $searchHitDto) => $searchHitDto->toArray(),
-                $hitsCollection
-            );
-
-            return Collection::make($hits);
-        }
-
-        return Collection::make($hitsCollection);
+        return Collection::make($hits);
     }
 }

tests/Integration/ClientTest.php

@@ -678,21 +678,8 @@ public function testSearchResponseCanBeConvertedToCollection(): void
 
         $this->assertInstanceOf(Collection::class, $result->toCollect());
 
-        /** @var SearchHitDto $hit */
-        foreach ($result->toCollect() as $hit) {
-            $this->assertSame('hello', $hit->getIndex());
-            $this->assertSame('183865906814918156', $hit->getId());
-            $this->assertSame(1.0, $hit->getScore());
-            $this->assertSame(['hello' => 'world'], $hit->getSource());
-        }
-
-        $this->assertInstanceOf(Collection::class, $result->toCollect(asArray: true));
-
-        foreach ($result->toCollect(asArray: true) as $hit) {
-            $this->assertSame('hello', $hit['index']);
-            $this->assertSame('183865906814918156', $hit['id']);
-            $this->assertSame(1.0, $hit['score']);
-            $this->assertSame(['hello' => 'world'], $hit['source']);
+        foreach ($result->toCollect() as $source) {
+            $this->assertSame(['hello' => 'world'], $source);
         }
     }
 }