fix regress tests - 9.4 .. 13devel

Author: okbob

expected/plpgsql_check_active-12.out

@@ -313,9 +313,9 @@ end;
 $$ language plpgsql;
 call proc(10);
 select * from plpgsql_check_function('proc(int)');
-             plpgsql_check_function              
--------------------------------------------------
- warning extra:00000:parameter "a" is never read
+          plpgsql_check_function          
+------------------------------------------
+ warning extra:00000:unused parameter "a"
 (1 row)
 
 create or replace procedure testproc()
@@ -360,9 +360,9 @@ $$ language plpgsql;
 select * from plpgsql_check_function('proc(int,int, int)');
              plpgsql_check_function              
 -------------------------------------------------
- warning extra:00000:parameter "a" is never read
- warning extra:00000:parameter "b" is never read
- warning extra:00000:parameter "c" is never read
+ warning extra:00000:unused parameter "a"
+ warning extra:00000:unused parameter "b"
+ warning extra:00000:unused parameter "c"
  warning extra:00000:unmodified OUT variable "b"
 (4 rows)
 
@@ -373,10 +373,9 @@ begin
 end;
 $$ language plpgsql;
 select * from plpgsql_check_function('proc(int,int, int)');
-             plpgsql_check_function              
--------------------------------------------------
- warning extra:00000:parameter "b" is never read
-(1 row)
+ plpgsql_check_function 
+------------------------
+(0 rows)
 
 create or replace procedure testproc()
 as $$
@@ -425,37 +424,35 @@ select * from plpgsql_check_function('testproc(int)');
 ------------------------
 (0 rows)
 
--- check assignement to recfield
-create table foo(a int);
-create or replace function test_field_assignment()
-returns void as $$
-declare v foo;
+drop procedure testproc(int);
+-- should to raise warnings
+create or replace procedure testproc2(in p1 int, inout p2 int, in p3 int, inout p4 int)
+as $$
 begin
-  v.a := 10;
-  v.a := current_timestamp;
-  raise notice '%', v;
+  raise notice '% %', p1, p3;
 end;
 $$ language plpgsql;
-select * from plpgsql_check_function('test_field_assignment');
-                              plpgsql_check_function                              
-----------------------------------------------------------------------------------
- warning:42804:5:assignment:target type is different type than source type
- Detail: cast "timestamp with time zone" value to "integer" type
- Hint: There are no possible explicit coercion between those types, possibly bug!
- Context: at assignment to field "a" of variable "v" declared on line 2
+select * from plpgsql_check_function('testproc2');
+              plpgsql_check_function              
+--------------------------------------------------
+ warning extra:00000:unused parameter "p2"
+ warning extra:00000:unused parameter "p4"
+ warning extra:00000:unmodified OUT variable "p2"
+ warning extra:00000:unmodified OUT variable "p4"
 (4 rows)
 
-drop table foo;
-create table foo(a int, b int);
-create or replace function foofunc()
-returns void as $$
+drop procedure testproc2;
+-- should be ok
+create or replace procedure testproc3(in p1 int, inout p2 int, in p3 int, inout p4 int)
+as $$
 begin
-  -- should be ok
-  perform * from foo;
+  p2 := p1;
+  p4 := p3;
 end;
 $$ language plpgsql;
-select * from plpgsql_check_function('foofunc');
+select * from plpgsql_check_function('testproc3');
  plpgsql_check_function 
 ------------------------
 (0 rows)
 
+drop procedure testproc3;