return query execute support

Author: okbob

expected/plpgsql_check_active.out

@@ -3806,3 +3806,72 @@ select * from plpgsql_check_function('dyn_sql_3');
 (4 rows)
 
 drop function dyn_sql_3();
+create or replace function dyn_sql_3()
+returns void as $$
+declare r record;
+begin
+  for r in execute 'select 1 as a, 2 as b'
+  loop
+    raise notice '%', r.a;
+  end loop;
+end
+$$ language plpgsql;
+-- should be ok
+select * from plpgsql_check_function('dyn_sql_3');
+ plpgsql_check_function 
+------------------------
+(0 rows)
+
+drop function dyn_sql_3();
+create or replace function dyn_sql_3()
+returns void as $$
+declare r record;
+begin
+  for r in execute 'select 1 as a, 2 as b'
+  loop
+    raise notice '%', r.c;
+  end loop;
+end
+$$ language plpgsql;
+-- should be error
+select * from plpgsql_check_function('dyn_sql_3');
+             plpgsql_check_function              
+-------------------------------------------------
+ error:42703:6:RAISE:record "r" has no field "c"
+ Context: SQL statement "SELECT r.c"
+(2 rows)
+
+drop function dyn_sql_3();
+create or replace function dyn_sql_4()
+returns table(ax int, bx int) as $$
+begin
+  return query execute 'select 10, 20';
+  return;
+end;
+$$ language plpgsql;
+-- should be ok
+select * from plpgsql_check_function('dyn_sql_4()');
+ plpgsql_check_function 
+------------------------
+(0 rows)
+
+create or replace function dyn_sql_4()
+returns table(ax int, bx int) as $$
+begin
+  return query execute 'select 10, 20, 30';
+  return;
+end;
+$$ language plpgsql;
+select * from dyn_sql_4();
+ERROR:  structure of query does not match function result type
+DETAIL:  Number of returned columns (3) does not match expected column count (2).
+CONTEXT:  PL/pgSQL function dyn_sql_4() line 3 at RETURN QUERY
+-- should be error
+select * from plpgsql_check_function('dyn_sql_4()');
+                              plpgsql_check_function                               
+-----------------------------------------------------------------------------------
+ error:42804:3:RETURN QUERY:structure of query does not match function result type
+ Detail: Number of returned columns (3) does not match expected column count (2).
+(2 rows)
+
+drop function dyn_sql_4();

sql/plpgsql_check_active.sql

@@ -2767,3 +2767,61 @@ $$ language plpgsql;
 select * from plpgsql_check_function('dyn_sql_3');
 
 drop function dyn_sql_3();
+
+create or replace function dyn_sql_3()
+returns void as $$
+declare r record;
+begin
+  for r in execute 'select 1 as a, 2 as b'
+  loop
+    raise notice '%', r.a;
+  end loop;
+end
+$$ language plpgsql;
+
+-- should be ok
+select * from plpgsql_check_function('dyn_sql_3');
+
+drop function dyn_sql_3();
+
+create or replace function dyn_sql_3()
+returns void as $$
+declare r record;
+begin
+  for r in execute 'select 1 as a, 2 as b'
+  loop
+    raise notice '%', r.c;
+  end loop;
+end
+$$ language plpgsql;
+
+-- should be error
+select * from plpgsql_check_function('dyn_sql_3');
+
+drop function dyn_sql_3();
+
+create or replace function dyn_sql_4()
+returns table(ax int, bx int) as $$
+begin
+  return query execute 'select 10, 20';
+  return;
+end;
+$$ language plpgsql;
+
+-- should be ok
+select * from plpgsql_check_function('dyn_sql_4()');
+
+create or replace function dyn_sql_4()
+returns table(ax int, bx int) as $$
+begin
+  return query execute 'select 10, 20, 30';
+  return;
+end;
+$$ language plpgsql;
+
+select * from dyn_sql_4();
+
+-- should be error
+select * from plpgsql_check_function('dyn_sql_4()');
+
+drop function dyn_sql_4();