Skip to content

Commit fe56d6e

Browse files
committed
selftests: net: local_termination: annotate the expected failures
Vladimir said when adding this test: The bridge driver fares particularly badly [...] mainly because it does not implement IFF_UNICAST_FLT. See commit 90b9566 ("selftests: forwarding: add a test for local_termination.sh"). We don't want to hide the known gaps, but having a test which always fails prevents us from catching regressions. Report the cases we know may fail as XFAIL. Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: Hangbin Liu <liuhangbin@gmail.com> Reviewed-by: Petr Machata <petrm@nvidia.com> Link: https://lore.kernel.org/r/20240516152513.1115270-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent f0fa841 commit fe56d6e

File tree

1 file changed

+18
-12
lines changed

1 file changed

+18
-12
lines changed

tools/testing/selftests/net/forwarding/local_termination.sh

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -155,25 +155,30 @@ run_test()
155155
"$smac > $MACVLAN_ADDR, ethertype IPv4 (0x0800)" \
156156
true
157157

158-
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \
159-
"$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \
160-
false
158+
xfail_on_veth $h1 \
159+
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \
160+
"$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \
161+
false
161162

162163
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, promisc" \
163164
"$smac > $UNKNOWN_UC_ADDR2, ethertype IPv4 (0x0800)" \
164165
true
165166

166-
check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address, allmulti" \
167-
"$smac > $UNKNOWN_UC_ADDR3, ethertype IPv4 (0x0800)" \
168-
false
167+
xfail_on_veth $h1 \
168+
check_rcv $rcv_if_name \
169+
"Unicast IPv4 to unknown MAC address, allmulti" \
170+
"$smac > $UNKNOWN_UC_ADDR3, ethertype IPv4 (0x0800)" \
171+
false
169172

170173
check_rcv $rcv_if_name "Multicast IPv4 to joined group" \
171174
"$smac > $JOINED_MACV4_MC_ADDR, ethertype IPv4 (0x0800)" \
172175
true
173176

174-
check_rcv $rcv_if_name "Multicast IPv4 to unknown group" \
175-
"$smac > $UNKNOWN_MACV4_MC_ADDR1, ethertype IPv4 (0x0800)" \
176-
false
177+
xfail_on_veth $h1 \
178+
check_rcv $rcv_if_name \
179+
"Multicast IPv4 to unknown group" \
180+
"$smac > $UNKNOWN_MACV4_MC_ADDR1, ethertype IPv4 (0x0800)" \
181+
false
177182

178183
check_rcv $rcv_if_name "Multicast IPv4 to unknown group, promisc" \
179184
"$smac > $UNKNOWN_MACV4_MC_ADDR2, ethertype IPv4 (0x0800)" \
@@ -187,9 +192,10 @@ run_test()
187192
"$smac > $JOINED_MACV6_MC_ADDR, ethertype IPv6 (0x86dd)" \
188193
true
189194

190-
check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \
191-
"$smac > $UNKNOWN_MACV6_MC_ADDR1, ethertype IPv6 (0x86dd)" \
192-
false
195+
xfail_on_veth $h1 \
196+
check_rcv $rcv_if_name "Multicast IPv6 to unknown group" \
197+
"$smac > $UNKNOWN_MACV6_MC_ADDR1, ethertype IPv6 (0x86dd)" \
198+
false
193199

194200
check_rcv $rcv_if_name "Multicast IPv6 to unknown group, promisc" \
195201
"$smac > $UNKNOWN_MACV6_MC_ADDR2, ethertype IPv6 (0x86dd)" \

0 commit comments

Comments
 (0)