Skip to content

Commit fa1ad9d

Browse files
YuuoniyMarc Zyngier
authored andcommitted
irqchip/gic-v3: Fix refcount leak in gic_populate_ppi_partitions
of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: e3825ba ("irqchip/gic-v3: Add support for partitioned PPIs") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220601080930.31005-6-linmq006@gmail.com
1 parent ec8401a commit fa1ad9d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/irqchip/irq-gic-v3.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1973,12 +1973,15 @@ static void __init gic_populate_ppi_partitions(struct device_node *gic_node)
19731973
continue;
19741974

19751975
cpu = of_cpu_node_to_id(cpu_node);
1976-
if (WARN_ON(cpu < 0))
1976+
if (WARN_ON(cpu < 0)) {
1977+
of_node_put(cpu_node);
19771978
continue;
1979+
}
19781980

19791981
pr_cont("%pOF[%d] ", cpu_node, cpu);
19801982

19811983
cpumask_set_cpu(cpu, &part->mask);
1984+
of_node_put(cpu_node);
19821985
}
19831986

19841987
pr_cont("}\n");

0 commit comments

Comments
 (0)