Skip to content

Commit ee7e551

Browse files
committed
openrisc: traps: Remove calls to show_registers before die
The die function calls show_registers unconditionally. Remove calls to show_registers before calling die to avoid printing all registers and stack status two times during a crash. This was found when testing kernel trap and floating point exception handling. Signed-off-by: Stafford Horne <shorne@gmail.com>
1 parent c8fdf82 commit ee7e551

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

arch/openrisc/kernel/traps.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ asmlinkage void do_unaligned_access(struct pt_regs *regs, unsigned long address)
212212
force_sig_fault(SIGBUS, BUS_ADRALN, (void __user *)address);
213213
} else {
214214
pr_emerg("KERNEL: Unaligned Access 0x%.8lx\n", address);
215-
show_registers(regs);
216215
die("Die:", regs, address);
217216
}
218217

@@ -225,7 +224,6 @@ asmlinkage void do_bus_fault(struct pt_regs *regs, unsigned long address)
225224
force_sig_fault(SIGBUS, BUS_ADRERR, (void __user *)address);
226225
} else { /* Kernel mode */
227226
pr_emerg("KERNEL: Bus error (SIGBUS) 0x%.8lx\n", address);
228-
show_registers(regs);
229227
die("Die:", regs, address);
230228
}
231229
}
@@ -421,7 +419,6 @@ asmlinkage void do_illegal_instruction(struct pt_regs *regs,
421419
} else { /* Kernel mode */
422420
pr_emerg("KERNEL: Illegal instruction (SIGILL) 0x%.8lx\n",
423421
address);
424-
show_registers(regs);
425422
die("Die:", regs, address);
426423
}
427424
}

0 commit comments

Comments
 (0)