Skip to content

Commit e6e3e00

Browse files
author
Marc Zyngier
committed
KVM: arm64: timer: Drop warning on failed interrupt signalling
We currently spit out a warning if making a timer interrupt pending fails. But not only this is loud and easy to trigger from userspace, we also fail to do anything useful with that information. Dropping the warning is the easiest thing to do for now. We can always add error reporting if we really want in the future. Reported-by: Alexander Potapenko <glider@google.com> Reviewed-by: Oliver Upton <oliver.upton@linux.dev> Link: https://lore.kernel.org/r/20250212182558.2865232-2-maz@kernel.org Signed-off-by: Marc Zyngier <maz@kernel.org>
1 parent b938731 commit e6e3e00

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

arch/arm64/kvm/arch_timer.c

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -447,21 +447,19 @@ static void kvm_timer_update_status(struct arch_timer_context *ctx, bool level)
447447
static void kvm_timer_update_irq(struct kvm_vcpu *vcpu, bool new_level,
448448
struct arch_timer_context *timer_ctx)
449449
{
450-
int ret;
451-
452450
kvm_timer_update_status(timer_ctx, new_level);
453451

454452
timer_ctx->irq.level = new_level;
455453
trace_kvm_timer_update_irq(vcpu->vcpu_id, timer_irq(timer_ctx),
456454
timer_ctx->irq.level);
457455

458-
if (!userspace_irqchip(vcpu->kvm)) {
459-
ret = kvm_vgic_inject_irq(vcpu->kvm, vcpu,
460-
timer_irq(timer_ctx),
461-
timer_ctx->irq.level,
462-
timer_ctx);
463-
WARN_ON(ret);
464-
}
456+
if (userspace_irqchip(vcpu->kvm))
457+
return;
458+
459+
kvm_vgic_inject_irq(vcpu->kvm, vcpu,
460+
timer_irq(timer_ctx),
461+
timer_ctx->irq.level,
462+
timer_ctx);
465463
}
466464

467465
/* Only called for a fully emulated timer */

0 commit comments

Comments
 (0)