Skip to content

Commit c9363bb

Browse files
Jarosław Janiktiwai
authored andcommitted
Revert "ALSA: hda/conexant: Mute speakers at suspend / shutdown"
Commit 4f61c8f ("ALSA: hda/conexant: Mute speakers at suspend / shutdown") mutes speakers on system shutdown or whenever HDA controller is suspended by PM; this however interacts badly with Thinkpad's ACPI firmware behavior which uses beeps to signal various events (enter/leave suspend or hibernation, AC power connect/disconnect, low battery, etc.); now those beeps are either muted altogether (for suspend/hibernate/ shutdown related events) or work more or less randomly (eg. AC plug/unplug is only audible when you are playing music at the moment, because HDA device is likely in suspend mode otherwise). Since the original bug report mentioned in 4f61c8f complained about Lenovo's Thinkpad laptop - revert this commit altogether. Fixes: 4f61c8f ("ALSA: hda/conexant: Mute speakers at suspend / shutdown") Signed-off-by: Jarosław Janik <jaroslaw.janik@gmail.com> Link: https://patch.msgid.link/20241030171813.18941-2-jaroslaw.janik@gmail.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent e49370d commit c9363bb

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

sound/pci/hda/patch_conexant.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,6 @@ static void cx_auto_shutdown(struct hda_codec *codec)
205205
{
206206
struct conexant_spec *spec = codec->spec;
207207

208-
snd_hda_gen_shutup_speakers(codec);
209-
210208
/* Turn the problematic codec into D3 to avoid spurious noises
211209
from the internal speaker during (and after) reboot */
212210
cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);

0 commit comments

Comments
 (0)