Skip to content

Commit ba1a587

Browse files
ricardonrafaeljw
authored andcommitted
thermal: intel: hfi: Shorten the thermal netlink event delay to 100ms
The delay between an HFI interrupt and its corresponding thermal netlink event has so far been hard-coded to CONFIG_HZ jiffies (1 second). This delay is too long for hardware that generates updates every tens of milliseconds. The HFI driver uses a delayed workqueue to send thermal netlink events. No subsequent events will be sent if there is pending work. As a result, much of the information of consecutive hardware updates will be lost if the workqueue delay is too long. User space entities may act on obsolete data. If the delay is too short, multiple events may overwhelm listeners. Set the delay to 100ms to strike a balance between too many and too few events. Use milliseconds instead of jiffies to improve readability. Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Acked-by: Zhang Rui <rui.zhang@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 564a88e commit ba1a587

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/thermal/intel/intel_hfi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ static struct hfi_features hfi_features;
166166
static DEFINE_MUTEX(hfi_instance_lock);
167167

168168
static struct workqueue_struct *hfi_updates_wq;
169-
#define HFI_UPDATE_DELAY HZ
169+
#define HFI_UPDATE_DELAY_MS 100
170170
#define HFI_MAX_THERM_NOTIFY_COUNT 16
171171

172172
static void get_hfi_caps(struct hfi_instance *hfi_instance,
@@ -322,7 +322,7 @@ void intel_hfi_process_event(__u64 pkg_therm_status_msr_val)
322322
raw_spin_unlock(&hfi_instance->event_lock);
323323

324324
queue_delayed_work(hfi_updates_wq, &hfi_instance->update_work,
325-
HFI_UPDATE_DELAY);
325+
msecs_to_jiffies(HFI_UPDATE_DELAY_MS));
326326
}
327327

328328
static void init_hfi_cpu_index(struct hfi_cpu_info *info)

0 commit comments

Comments
 (0)