Skip to content

Commit b7ff9ef

Browse files
rtc: rx8111: demote warnings to debug level
The proper way for userspace to react on a read time error is to have a look at the voltage low information. There is no point in cluttering dmesg as it is often not even visible to the end user. Reviewed-by: Waqar Hameed <waqar.hameed@axis.com> Link: https://lore.kernel.org/r/20240417191937.33790-1-alexandre.belloni@bootlin.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 6a216cb commit b7ff9ef

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/rtc/rtc-rx8111.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,14 +170,14 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
170170
}
171171

172172
if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) {
173-
dev_warn(data->dev,
174-
"Crystal oscillation stopped, time is not reliable\n");
173+
dev_dbg(data->dev,
174+
"Crystal oscillation stopped, time is not reliable\n");
175175
return -EINVAL;
176176
}
177177

178178
if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) {
179-
dev_warn(data->dev,
180-
"Low voltage detected, time is not reliable\n");
179+
dev_dbg(data->dev,
180+
"Low voltage detected, time is not reliable\n");
181181
return -EINVAL;
182182
}
183183

@@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
188188
}
189189

190190
if (regval) {
191-
dev_warn(data->dev, "Clock stopped, time is not reliable\n");
191+
dev_dbg(data->dev, "Clock stopped, time is not reliable\n");
192192
return -EINVAL;
193193
}
194194

0 commit comments

Comments
 (0)