Skip to content

Commit ae9daff

Browse files
ij-inteltsbogend
authored andcommitted
MIPS: Routerboard 532: Fix vendor retry check code
read_config_dword() contains strange condition checking ret for a number of values. The ret variable, however, is always zero because config_access() never returns anything else. Thus, the retry is always taken until number of tries is exceeded. The code looks like it wants to check *val instead of ret to see if the read gave an error response. Fixes: 73b4390 ("[MIPS] Routerboard 532: Support for base system") Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
1 parent 83a7eef commit ae9daff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/mips/pci/ops-rc32434.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ static int read_config_dword(struct pci_bus *bus, unsigned int devfn,
112112
* gives them time to settle
113113
*/
114114
if (where == PCI_VENDOR_ID) {
115-
if (ret == 0xffffffff || ret == 0x00000000 ||
116-
ret == 0x0000ffff || ret == 0xffff0000) {
115+
if (*val == 0xffffffff || *val == 0x00000000 ||
116+
*val == 0x0000ffff || *val == 0xffff0000) {
117117
if (delay > 4)
118118
return 0;
119119
delay *= 2;

0 commit comments

Comments
 (0)