Skip to content

Commit a94ff8e

Browse files
javiercarrascocruzgroeck
authored andcommitted
hwmon: (ltc2992) Fix memory leak in ltc2992_parse_dt()
A new error path was added to the fwnode_for_each_available_node() loop in ltc2992_parse_dt(), which leads to an early return that requires a call to fwnode_handle_put() to avoid a memory leak in that case. Add the missing fwnode_handle_put() in the error path from a zero value shunt resistor. Cc: stable@vger.kernel.org Fixes: 10b0290 ("hwmon: (ltc2992) Avoid division by zero") Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Link: https://lore.kernel.org/r/20240523-fwnode_for_each_available_child_node_scoped-v2-1-701f3a03f2fb@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent fa0bc8f commit a94ff8e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/hwmon/ltc2992.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -876,9 +876,11 @@ static int ltc2992_parse_dt(struct ltc2992_state *st)
876876

877877
ret = fwnode_property_read_u32(child, "shunt-resistor-micro-ohms", &val);
878878
if (!ret) {
879-
if (!val)
879+
if (!val) {
880+
fwnode_handle_put(child);
880881
return dev_err_probe(&st->client->dev, -EINVAL,
881882
"shunt resistor value cannot be zero\n");
883+
}
882884
st->r_sense_uohm[addr] = val;
883885
}
884886
}

0 commit comments

Comments
 (0)